From: giometti@linux.it (Rodolfo Giometti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm pxa: remove "direction input" forcing for IRQ GPIOs
Date: Tue, 17 Nov 2009 12:21:46 +0100 [thread overview]
Message-ID: <1258456906-12338-1-git-send-email-giometti@linux.it> (raw)
PXA CPUs may use their GPIOs as IRQ lines even if they are selected as
outputs (see for example figure 24-1 into PXA27x Processor Family
Developer's Manual). So forcing GPIOs IRQ lines as inputs is not
correct.
Programmers should set up GPIOs direction according to their usage and
the function pxa_gpio_irq_type() should simply enable the IRQ
detection.
Signed-off-by: Rodolfo Giometti <giometti@linux.it>
Cc: raffaele.recalcati at bticino.it
---
arch/arm/plat-pxa/gpio.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/plat-pxa/gpio.c b/arch/arm/plat-pxa/gpio.c
index 98548c6..3f17221 100644
--- a/arch/arm/plat-pxa/gpio.c
+++ b/arch/arm/plat-pxa/gpio.c
@@ -176,13 +176,6 @@ static int pxa_gpio_irq_type(unsigned int irq, unsigned int type)
type = IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING;
}
- gpdr = __raw_readl(c->regbase + GPDR_OFFSET);
-
- if (__gpio_is_inverted(gpio))
- __raw_writel(gpdr | mask, c->regbase + GPDR_OFFSET);
- else
- __raw_writel(gpdr & ~mask, c->regbase + GPDR_OFFSET);
-
if (type & IRQ_TYPE_EDGE_RISING)
c->irq_edge_rise |= mask;
else
--
1.6.3.3
next reply other threads:[~2009-11-17 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 11:21 Rodolfo Giometti [this message]
2009-11-17 11:44 ` [PATCH] arm pxa: remove "direction input" forcing for IRQ GPIOs Daniel Mack
2009-11-17 12:05 ` Rodolfo Giometti
2009-11-17 12:12 ` Eric Miao
2009-11-17 12:34 ` Daniel Mack
2009-11-17 12:37 ` Rodolfo Giometti
2009-11-17 12:43 ` Daniel Mack
2009-11-17 12:59 ` Rodolfo Giometti
2009-11-17 13:06 ` Daniel Mack
2009-11-17 13:16 ` Rodolfo Giometti
2009-11-17 14:38 ` Rodolfo Giometti
2009-11-17 17:11 ` Daniel Mack
2009-11-17 18:02 ` Rodolfo Giometti
2009-11-17 19:28 ` Russell King - ARM Linux
2009-11-17 17:00 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258456906-12338-1-git-send-email-giometti@linux.it \
--to=giometti@linux.it \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).