From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [[clock v2]] ARM: S3C64XX: Fixup .reg_src and .reg_div with named initialisers
Date: Tue, 8 Dec 2009 02:07:25 +0000 [thread overview]
Message-ID: <1260238045-12694-9-git-send-email-ben-linux@fluff.org> (raw)
In-Reply-To: <1260238045-12694-1-git-send-email-ben-linux@fluff.org>
Change these two fields to have named initialisers as per the
review comments from Kyungmin Park.
sed used:
s@\.reg_src\(.*\)=\(.*\){\(.*\),\(.*\),\(.*\)}@.reg_src\1=\2{ .reg =\3, .shift =\4, .size =\5 }@g
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
arch/arm/plat-s3c64xx/s3c6400-clock.c | 28 ++++++++++++++--------------
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/arm/plat-s3c64xx/s3c6400-clock.c b/arch/arm/plat-s3c64xx/s3c6400-clock.c
index 79e4bd7..8f6a0d1 100644
--- a/arch/arm/plat-s3c64xx/s3c6400-clock.c
+++ b/arch/arm/plat-s3c64xx/s3c6400-clock.c
@@ -68,7 +68,7 @@ static struct clksrc_clk clk_mout_apll = {
.name = "mout_apll",
.id = -1,
},
- .reg_src = { S3C_CLK_SRC, 0, 1 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 0, .size = 1 },
.sources = &clk_src_apll,
};
@@ -92,7 +92,7 @@ static struct clksrc_clk clk_mout_epll = {
.name = "mout_epll",
.id = -1,
},
- .reg_src = { S3C_CLK_SRC, 2, 1 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 2, .size = 1 },
.sources = &clk_src_epll,
};
@@ -111,7 +111,7 @@ static struct clksrc_clk clk_mout_mpll = {
.name = "mout_mpll",
.id = -1,
},
- .reg_src = { S3C_CLK_SRC, 1, 1 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 1, .size = 1 },
.sources = &clk_src_mpll,
};
@@ -317,7 +317,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_MMC0,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 18, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 18, .size = 2 },
.reg_div = { S3C_CLK_DIV1, 0, 4 },
.sources = &clkset_spi_mmc,
}, {
@@ -327,7 +327,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_MMC1,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 20, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 20, .size = 2 },
.reg_div = { S3C_CLK_DIV1, 4, 4 },
.sources = &clkset_spi_mmc,
}, {
@@ -337,7 +337,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_MMC2,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 22, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 22, .size = 2 },
.reg_div = { S3C_CLK_DIV1, 8, 4 },
.sources = &clkset_spi_mmc,
}, {
@@ -347,7 +347,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_UHOST,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 5, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 5, .size = 2 },
.reg_div = { S3C_CLK_DIV1, 20, 4 },
.sources = &clkset_uhost,
}, {
@@ -357,7 +357,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_UART,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 13, 1 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 13, .size = 1 },
.reg_div = { S3C_CLK_DIV2, 16, 4 },
.sources = &clkset_uart,
}, {
@@ -368,7 +368,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_SPI0,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 14, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 14, .size = 2 },
.reg_div = { S3C_CLK_DIV2, 0, 4 },
.sources = &clkset_spi_mmc,
}, {
@@ -378,7 +378,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_SPI1,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 16, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 16, .size = 2 },
.reg_div = { S3C_CLK_DIV2, 4, 4 },
.sources = &clkset_spi_mmc,
}, {
@@ -388,7 +388,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_AUDIO0,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 7, 3 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 7, .size = 3 },
.reg_div = { S3C_CLK_DIV2, 8, 4 },
.sources = &clkset_audio0,
}, {
@@ -398,7 +398,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_AUDIO1,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 10, 3 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 10, .size = 3 },
.reg_div = { S3C_CLK_DIV2, 12, 4 },
.sources = &clkset_audio1,
}, {
@@ -408,7 +408,7 @@ static struct clksrc_clk clksrcs[] = {
.ctrlbit = S3C_CLKCON_SCLK_IRDA,
.enable = s3c64xx_sclk_ctrl,
},
- .reg_src = { S3C_CLK_SRC, 24, 2 },
+ .reg_src = { .reg = S3C_CLK_SRC, .shift = 24, .size = 2 },
.reg_div = { S3C_CLK_DIV2, 20, 4 },
.sources = &clkset_irda,
}, {
@@ -419,7 +419,7 @@ static struct clksrc_clk clksrcs[] = {
.enable = s3c64xx_sclk_ctrl,
},
.reg_div = { S3C_CLK_DIV0, 20, 4 },
- .reg_src = { NULL, 0, 0 },
+ .reg_src = { .reg = NULL, .shift = 0, .size = 0 },
.sources = &clkset_camif,
},
};
--
1.5.6.5
prev parent reply other threads:[~2009-12-08 2:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 2:07 Samsung clock updates v2 Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: SAMSUNG: Move <plat/clock.h> to plat-samsung Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: S3C64XX: Cleanup common init code in s3c6400-clock.c Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: S3C64XX: Compress s3c6400-clock.c code Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: SAMSUNG: Add core clock implementation for clksrc based clocks Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: S3C64XX: Use new clock-clksrc.c code for clocks Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: S3C64XX: Remove unused clock definitions from clock header Ben Dooks
2009-12-08 2:07 ` [[clock v2]] ARM: SAMSUNG: Reduce size of struct clk Ben Dooks
2009-12-08 2:07 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260238045-12694-9-git-send-email-ben-linux@fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).