From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: dma_cache_maint_contiguous should be patched asdma_cache_maint do
Date: Fri, 11 Dec 2009 09:36:05 +0000 [thread overview]
Message-ID: <1260524165.3109.3.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <SNT109-W5125384E245D2B1026CD6DA78D0@phx.gbl>
On Thu, 2009-12-10 at 18:45 +0000, mkl lin wrote:
> >> Good point, that's actually a quick modification (2-3 lines in each
> >> cache function). Mac Lin, can you try the patch below (without the other
> >> broadcasting patch)? If it works, I'll add some comment:
> > I have tested with my patch, and it seems good. No data integrity
> > issue, nor any deadlock.
>
> BTW, read performance drops from 64MBps to 44MBps on my platform.
Is this compared to the IPI patch or to the UP (maxcpus=1) version?
You can try placing a "pld [r0, #32] before the new ldr/str so that it
fetches the next cache line while the loop is dealing with the current
one.
Thanks.
--
Catalin
next prev parent reply other threads:[~2009-12-11 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 14:59 dma_cache_maint_contiguous should be patched as dma_cache_maint do mkl lin
2009-12-10 15:35 ` Catalin Marinas
2009-12-10 16:39 ` Russell King - ARM Linux
2009-12-10 17:15 ` dma_cache_maint_contiguous should be patched asdma_cache_maint do Catalin Marinas
2009-12-10 17:39 ` Russell King - ARM Linux
2009-12-10 18:30 ` mkl lin
2009-12-10 18:45 ` mkl lin
2009-12-11 9:36 ` Catalin Marinas [this message]
2009-12-11 12:32 ` mkl lin
2009-12-16 20:33 ` Russell King - ARM Linux
2009-12-17 5:08 ` mkl lin
2009-12-18 12:49 ` Richard Liu
2009-12-10 21:21 ` dma_cache_maint_contiguous should be patched as dma_cache_maint do Nicolas Pitre
2009-12-10 22:14 ` Russell King - ARM Linux
2009-12-11 1:24 ` Nicolas Pitre
2009-12-11 10:56 ` dma_cache_maint_contiguous should be patched asdma_cache_maint do Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260524165.3109.3.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).