From: maramaopercheseimorto@gmail.com (Alberto Panizzo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] regulator: mc13783-regulator: correct the probing time.
Date: Mon, 14 Dec 2009 18:53:35 +0100 [thread overview]
Message-ID: <1260813215.2022.171.camel@climbing-alby> (raw)
In-Reply-To: <1260811598.2022.144.camel@climbing-alby>
When the mc13783-regulator driver is built in kernel, probing it during
the regulator subsystem initialisation result in a fault.
That is because regulator subsystem is planned to be initialised very early
in the boot process, before the mfd subsystem initialisation.
The mc12783-regulator probing process need to access to the mc13783-core
functionality to read/write mc13783 registers and so must be called after
the mc13783-core driver initialisation.
The way to do this is to let the kernel probe the mc13783-regulator driver when
mc13783-core register his regulator subdevice.
Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
---
drivers/regulator/mc13783-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index 3d5d349..a40e35a 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -509,12 +509,12 @@ static struct platform_driver mc13783_regulator_driver = {
.owner = THIS_MODULE,
},
.remove = __devexit_p(mc13783_regulator_remove),
+ .probe = mc13783_regulator_probe,
};
static int __init mc13783_regulator_init(void)
{
- return platform_driver_probe(&mc13783_regulator_driver,
- mc13783_regulator_probe);
+ return platform_driver_register(&mc13783_regulator_driver);
}
subsys_initcall(mc13783_regulator_init);
--
1.6.3.3
next prev parent reply other threads:[~2009-12-14 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 16:41 [PATCH 0/4 v2] Patch series for introduce voltage selecting for mc13783 regulators Alberto Panizzo
2009-12-14 17:12 ` [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register Alberto Panizzo
2009-12-14 17:18 ` [PATCH 2/4] mfd: mc13783: When probing, unlock the mc13783 before subsystems initialisation Alberto Panizzo
2009-12-14 17:26 ` [PATCH 3/4] regulator: add voltage selection capability to mc13783 regulators v2 Alberto Panizzo
2009-12-14 17:53 ` Alberto Panizzo [this message]
2009-12-15 14:50 ` [PATCH 4/4] regulator: mc13783-regulator: correct the probing time Liam Girdwood
2009-12-15 14:52 ` Mark Brown
2009-12-15 14:54 ` [PATCH 3/4] regulator: add voltage selection capability to mc13783 regulators v2 Liam Girdwood
2009-12-18 16:12 ` [PATCH 2/4] mfd: mc13783: When probing, unlock the mc13783 before subsystems initialisation Alberto Panizzo
2009-12-19 20:18 ` Uwe Kleine-König
2009-12-20 13:48 ` Alberto Panizzo
2009-12-20 18:49 ` Uwe Kleine-König
2009-12-20 22:50 ` Alberto Panizzo
2010-01-08 11:13 ` Alberto Panizzo
2010-01-08 11:44 ` Samuel Ortiz
[not found] ` <4B26799F.1020507@ru.mvista.com>
2009-12-14 17:59 ` [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register Alberto Panizzo
2010-01-05 18:15 ` Samuel Ortiz
2010-01-05 19:55 ` Uwe Kleine-König
2010-01-08 10:53 ` Alberto Panizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260813215.2022.171.camel@climbing-alby \
--to=maramaopercheseimorto@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).