From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Add SWP/SWPB emulation for ARMv7 processors
Date: Fri, 18 Dec 2009 10:00:02 +0000 [thread overview]
Message-ID: <1261130402.13520.1.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20091217193210.GD362@shareable.org>
On Thu, 2009-12-17 at 19:32 +0000, Jamie Lokier wrote:
> Leif Lindholm wrote:
> > + printk(KERN_INFO "SWP{B} emulation: access caused memory abort!\n");
> > + arm_notify_die("Illegal memory access", regs, &info, 0, 0);
>
> > + if (address & 0x3) {
> > + /* SWP to unaligned address not permitted */
> > + printk(KERN_INFO "SWP instruction on unaligned pointer!\n");
> > + return -EFAULT;
> > + }
>
> These printks look like an easy local denial of service. They should
> be rate limited.
pr_debug() may be a better choice.
--
Catalin
next prev parent reply other threads:[~2009-12-18 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 17:54 [PATCH] ARM: Add SWP/SWPB emulation for ARMv7 processors Leif Lindholm
2009-12-17 18:19 ` Woodruff, Richard
2009-12-17 19:16 ` Jamie Lokier
2009-12-17 20:43 ` Woodruff, Richard
2009-12-18 20:31 ` Jamie Lokier
2010-01-08 23:20 ` Woodruff, Richard
2009-12-18 14:15 ` Leif Lindholm
2009-12-17 19:32 ` Jamie Lokier
2009-12-18 10:00 ` Catalin Marinas [this message]
2009-12-18 10:06 ` Catalin Marinas
2009-12-18 17:01 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261130402.13520.1.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).