linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: me@felipebalbi.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling
Date: Wed, 30 Dec 2009 15:14:41 +0200	[thread overview]
Message-ID: <1262178881.17250.1.camel@gandalf> (raw)
In-Reply-To: <4B3B504B.4020602@ru.mvista.com>

Hi,

On Wed, 2009-12-30 at 16:06 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> Felipe Balbi wrote:
> 
> >>    Why always "ick"?! Do you think OMAPs are the only boards using MUSB 
> >> out there?
> >>     
> >
> > err, I'm afraid you have to read more about clock framework. The clock
> > name should not matter when you issue clk_get().
> 
>    It depends on the matching type determined from a clkdev matching 
> table -- see dm644x_clks[] in arch/mach-davinci/dm644x.c as an example: 
> 'struct davinci_clk' incorporates 'struct clk_lookup', and where its 1st 
> member is initialized, the matching is done by device, where its second 
> member is initialized, the matching is done by clock name -- see 
> clk_find() in arch/arm/common/clkdev.c for the logic.

diff --git a/arch/arm/mach-davinci/dm644x.c
b/arch/arm/mach-davinci/dm644x.c
index 2cd0081..a0ad7b6 100644
--- a/arch/arm/mach-davinci/dm644x.c
+++ b/arch/arm/mach-davinci/dm644x.c
@@ -306,7 +306,7 @@ struct davinci_clk dm644x_clks[] = {
        CLK("davinci_mmc.0", NULL, &mmcsd_clk),
        CLK(NULL, "spi", &spi_clk),
        CLK(NULL, "gpio", &gpio_clk),
-       CLK(NULL, "usb", &usb_clk),
+       CLK("musb_hdrc", "usb", &usb_clk),
        CLK(NULL, "vlynq", &vlynq_clk),
        CLK(NULL, "aemif", &aemif_clk),
        CLK(NULL, "pwm0", &pwm0_clk),


there you are...

-- 
balbi

  parent reply	other threads:[~2009-12-30 13:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 22:59 [patch-v2.6.34 0/9] arm omap patches for -next merge window Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 1/9] arm: omap: musb: remove unused data Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 2/9] arm: omap: musb: we can use clk framework Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 3/9] arm: omap: musb: remove unused soft_con field Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 4/9] arm: omap: musb: remove unused dma data Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 5/9] arm: omap: musb: remove unnecessary return Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 6/9] arm: omap: gpmc: avoid section definitions on headers Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling Felipe Balbi
     [not found]   ` <4B3B3720.9070205@ru.mvista.com>
2009-12-30 11:53     ` Felipe Balbi
     [not found]       ` <4B3B504B.4020602@ru.mvista.com>
2009-12-30 13:14         ` Felipe Balbi [this message]
2009-12-30 13:20           ` Felipe Balbi
     [not found]           ` <4B3B54E1.9010600@ru.mvista.com>
2009-12-30 13:29             ` Felipe Balbi
     [not found]               ` <4B3B58F0.2070903@ru.mvista.com>
2009-12-30 13:46                 ` Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 8/9] arm: omap: musb: do not pass clock name to driver Felipe Balbi
     [not found]   ` <4B3B3818.5030804@ru.mvista.com>
2009-12-30 11:55     ` Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 9/9] arm: omap: musb: get rid of dyn_fifo Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262178881.17250.1.camel@gandalf \
    --to=me@felipebalbi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).