[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[Santosh Shilimkar]

The file arch/arm/include/asm/cpu.h needs to include 'linux/cpu.h' to
meet its dependency. Otherwise when using "struct cpuinfo_arm" and including
just 'asm/cpu.h' throws below error -
	arch/arm/include/asm/cpu.h:16: error: field 'cpu' has incomplete type

To fix this  otherway, one can also include both linux/cpu.h and asm/cpu.h
ubut it shoudn't be that way. So this patch fixes this by including the
linux/cpu.h in asm/cpu.h,so that including alone asm/cpu.h is enough.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/include/asm/cpu.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/include/asm/cpu.h b/arch/arm/include/asm/cpu.h
index 634b2d7..7939681 100644
--- a/arch/arm/include/asm/cpu.h
+++ b/arch/arm/include/asm/cpu.h
@@ -11,6 +11,7 @@
 #define __ASM_ARM_CPU_H
 
 #include <linux/percpu.h>
+#include <linux/cpu.h>
 
 struct cpuinfo_arm {
 	struct cpu	cpu;
-- 
1.6.0.4

[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[Shilimkar, Santosh]

Russell,
Any comments on this patch ?
> -----Original Message-----
> From: Shilimkar, Santosh
> Sent: Sunday, January 03, 2010 5:05 PM
> To: linux at arm.linux.org.uk
> Cc: linux-arm-kernel at lists.infradead.org; tony at atomide.com; Shilimkar, Santosh
> Subject: [PATCH] ARM: include needed linux/cpu.h in asm/cpu.h
> 
> The file arch/arm/include/asm/cpu.h needs to include 'linux/cpu.h' to
> meet its dependency. Otherwise when using "struct cpuinfo_arm" and including
> just 'asm/cpu.h' throws below error -
> 	arch/arm/include/asm/cpu.h:16: error: field 'cpu' has incomplete type
> 
> To fix this  otherway, one can also include both linux/cpu.h and asm/cpu.h
> ubut it shoudn't be that way. So this patch fixes this by including the
> linux/cpu.h in asm/cpu.h,so that including alone asm/cpu.h is enough.
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
>  arch/arm/include/asm/cpu.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/cpu.h b/arch/arm/include/asm/cpu.h
> index 634b2d7..7939681 100644
> --- a/arch/arm/include/asm/cpu.h
> +++ b/arch/arm/include/asm/cpu.h
> @@ -11,6 +11,7 @@
>  #define __ASM_ARM_CPU_H
> 
>  #include <linux/percpu.h>
> +#include <linux/cpu.h>
> 
>  struct cpuinfo_arm {
>  	struct cpu	cpu;
> --
> 1.6.0.4

[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[Russell King - ARM Linux]

On Thu, Jan 07, 2010 at 01:14:57PM +0530, Shilimkar, Santosh wrote:
> Russell,
> Any comments on this patch ?

I think it's fine, so please throw it at the patch system, thanks.

[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[Russell King - ARM Linux]

On Thu, Jan 07, 2010 at 01:14:57PM +0530, Shilimkar, Santosh wrote:
> > -----Original Message-----
> > From: Shilimkar, Santosh
> > Sent: Sunday, January 03, 2010 5:05 PM
> > To: linux at arm.linux.org.uk
> > Cc: linux-arm-kernel at lists.infradead.org; tony at atomide.com; Shilimkar, Santosh
> > Subject: [PATCH] ARM: include needed linux/cpu.h in asm/cpu.h
> > 
> > The file arch/arm/include/asm/cpu.h needs to include 'linux/cpu.h' to
> > meet its dependency. Otherwise when using "struct cpuinfo_arm" and including
> > just 'asm/cpu.h' throws below error -
> > 	arch/arm/include/asm/cpu.h:16: error: field 'cpu' has incomplete type
> > 
> > To fix this  otherway, one can also include both linux/cpu.h and asm/cpu.h
> > ubut it shoudn't be that way. So this patch fixes this by including the
> > linux/cpu.h in asm/cpu.h,so that including alone asm/cpu.h is enough.

The version in the patch system had most of the above sentence on one
line.  This is not acceptable; it has to be sensibly manually wrapped
otherwise Linus complains.

Please ensure that future submissions are wrapped preferably before
column 72, thanks.

[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

[Shilimkar, Santosh]

> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Sunday, January 10, 2010 6:37 PM
> To: Shilimkar, Santosh
> Cc: linux-arm-kernel at lists.infradead.org; tony at atomide.com
> Subject: Re: [PATCH] ARM: include needed linux/cpu.h in asm/cpu.h
> 
> On Thu, Jan 07, 2010 at 01:14:57PM +0530, Shilimkar, Santosh wrote:
> > > -----Original Message-----
> > > From: Shilimkar, Santosh
> > > Sent: Sunday, January 03, 2010 5:05 PM
> > > To: linux at arm.linux.org.uk
> > > Cc: linux-arm-kernel at lists.infradead.org; tony at atomide.com; Shilimkar, Santosh
> > > Subject: [PATCH] ARM: include needed linux/cpu.h in asm/cpu.h
> > >
> > > The file arch/arm/include/asm/cpu.h needs to include 'linux/cpu.h' to
> > > meet its dependency. Otherwise when using "struct cpuinfo_arm" and including
> > > just 'asm/cpu.h' throws below error -
> > > 	arch/arm/include/asm/cpu.h:16: error: field 'cpu' has incomplete type
> > >
> > > To fix this  otherway, one can also include both linux/cpu.h and asm/cpu.h
> > > ubut it shoudn't be that way. So this patch fixes this by including the
> > > linux/cpu.h in asm/cpu.h,so that including alone asm/cpu.h is enough.
> 
> The version in the patch system had most of the above sentence on one
> line.  This is not acceptable; it has to be sensibly manually wrapped
> otherwise Linus complains.
> 
> Please ensure that future submissions are wrapped preferably before
> column 72, thanks.
Thanks for correction. Will ensure this next time.