From mboxrd@z Thu Jan 1 00:00:00 1970 From: rpurdie@rpsys.net (Richard Purdie) Date: Fri, 08 Jan 2010 12:27:28 +0000 Subject: [PATCH v2 06/09] backlight: enable backlight in 88pm860x In-Reply-To: <20100108110646.GB3734@sortiz.org> References: <771cded00912090515k39cccec9od78addb8e127f491@mail.gmail.com> <20100108110646.GB3734@sortiz.org> Message-ID: <1262953648.10097.34.camel@dax.rpnet.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2010-01-08 at 12:06 +0100, Samuel Ortiz wrote: > Hi Haojian, Richard, > > On Wed, Dec 09, 2009 at 08:15:28AM -0500, Haojian Zhuang wrote: > > From 8d2bc9826f758f113fde6f3fd01723111fbf2a91 Mon Sep 17 00:00:00 2001 > > From: Haojian Zhuang > > Date: Mon, 9 Nov 2009 12:41:07 -0500 > > Subject: [PATCH] backlight: enable backlight in 88pm860x > > > > At most, three backlight device can be supported in 88pm860x driver. > I applied this patch and the LED one to my for-next branch. > Richard, whenever you have time for that, could you please quickly check if > they oook ok to you ? They're 2.6.34 material, so no rush here. I had a look through, they look basically ok. In the LED patch I'm not sure I like the SET_BRIGHTNESS and SET_BLINK sharing of a workqueue though. Its not going to crash, I can just see values potentially getting lost as the code has a race condition. It would be easier if it just compared led->current_brightness to led->brightness acting if needed and something similar for LED blinking. Cheers, Richard -- Richard Purdie Intel Open Source Technology Centre