From: rpurdie@rpsys.net (Richard Purdie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/09] backlight: enable backlight in 88pm860x
Date: Tue, 12 Jan 2010 09:32:25 +0000 [thread overview]
Message-ID: <1263288745.17518.65.camel@ted> (raw)
In-Reply-To: <771cded01001110032s7fe62605g72cdb50b73d0d53@mail.gmail.com>
On Mon, 2010-01-11 at 03:32 -0500, Haojian Zhuang wrote:
> On Fri, Jan 8, 2010 at 7:27 AM, Richard Purdie <rpurdie@rpsys.net> >
> In the LED patch I'm not sure I like the SET_BRIGHTNESS and SET_BLINK
> > sharing of a workqueue though. Its not going to crash, I can just see
> > values potentially getting lost as the code has a race condition. It
> > would be easier if it just compared led->current_brightness to
> > led->brightness acting if needed and something similar for LED blinking.
>
> Excuse me that there's a mutex lock in __led_set(). Both
> SET_BRIGHTNESS & SET_BLINK calls __led_set(). There shouldn't be race
> condition on set led. What's your opinion?
There is a race condition since if you get a blink and brightness set
call at around the same time, only one of them will end up being
applied. Its not going to crash but its also less than ideal.
Cheers,
Richard
prev parent reply other threads:[~2010-01-12 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 13:15 [PATCH v2 06/09] backlight: enable backlight in 88pm860x Haojian Zhuang
2010-01-08 11:06 ` Samuel Ortiz
2010-01-08 12:27 ` Richard Purdie
2010-01-11 8:32 ` Haojian Zhuang
2010-01-12 9:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263288745.17518.65.camel@ted \
--to=rpurdie@rpsys.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).