From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Tidy up common code in s3c64xx_spi_set_info()
Date: Thu, 21 Jan 2010 05:21:06 +0000 [thread overview]
Message-ID: <1264051266-18754-2-git-send-email-ben-linux@fluff.org> (raw)
In-Reply-To: <1264051266-18754-1-git-send-email-ben-linux@fluff.org>
The s3c64xx_spi_set_info() sets one of two platform data structures depending
on which controller is being specified. Change to taking a pointer to the
relevant platform data structure and then having one set of code to place
the data into the area being pointed to.
Cc: Jassi Brar <jassi.brar@samsung.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
arch/arm/plat-s3c64xx/dev-spi.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/arm/plat-s3c64xx/dev-spi.c b/arch/arm/plat-s3c64xx/dev-spi.c
index 6b6d7af..ca10388 100644
--- a/arch/arm/plat-s3c64xx/dev-spi.c
+++ b/arch/arm/plat-s3c64xx/dev-spi.c
@@ -18,6 +18,7 @@
#include <mach/gpio.h>
#include <plat/spi-clocks.h>
+
#include <plat/s3c64xx-spi.h>
#include <plat/gpio-bank-c.h>
#include <plat/gpio-cfg.h>
@@ -154,6 +155,8 @@ EXPORT_SYMBOL(s3c64xx_device_spi1);
void __init s3c64xx_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
{
+ struct s3c64xx_spi_info *pd;
+
/* Reject invalid configuration */
if (!num_cs || src_clk_nr < 0
|| src_clk_nr > S3C64XX_SPI_SRCCLK_48M) {
@@ -163,18 +166,18 @@ void __init s3c64xx_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
switch (cntrlr) {
case 0:
- s3c64xx_spi0_pdata.num_cs = num_cs;
- s3c64xx_spi0_pdata.src_clk_nr = src_clk_nr;
- s3c64xx_spi0_pdata.src_clk_name = spi_src_clks[src_clk_nr];
+ pd = &s3c64xx_spi0_pdata;
break;
case 1:
- s3c64xx_spi1_pdata.num_cs = num_cs;
- s3c64xx_spi1_pdata.src_clk_nr = src_clk_nr;
- s3c64xx_spi1_pdata.src_clk_name = spi_src_clks[src_clk_nr];
+ pd = &s3c64xx_spi1_pdata;
break;
default:
printk(KERN_ERR "%s: Invalid SPI controller(%d)\n",
__func__, cntrlr);
return;
}
+
+ pd->num_cs = num_cs;
+ pd->src_clk_nr = src_clk_nr;
+ pd->src_clk_name = spi_src_clks[src_clk_nr];
}
--
1.6.0.4
next prev parent reply other threads:[~2010-01-21 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 5:21 Tidy for S3C64XX SPI device code Ben Dooks
2010-01-21 5:21 ` Ben Dooks [this message]
2010-01-21 6:11 ` [PATCH] ARM: S3C64XX: Tidy up common code in s3c64xx_spi_set_info() jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264051266-18754-2-git-send-email-ben-linux@fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).