* [PATCH 1/2] ARM: S3C2412: SoC has the fractional baud rate register
@ 2010-01-27 16:38 Michel Pollet
2010-01-27 16:38 ` [PATCH 2/2] ARM: S3C: Configuration override for UART names Michel Pollet
0 siblings, 1 reply; 3+ messages in thread
From: Michel Pollet @ 2010-01-27 16:38 UTC (permalink / raw)
To: linux-arm-kernel
The S3C2412 has a fractional baud rate register, this patch adds the
corresponding flag to the UART definition to allow generation of more
precise baud rates for the various clock combinations.
Signed-off-by: Michel Pollet <buserror@gmail.com>
---
drivers/serial/s3c2412.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/s3c2412.c b/drivers/serial/s3c2412.c
index ce75e28..1700b1a 100644
--- a/drivers/serial/s3c2412.c
+++ b/drivers/serial/s3c2412.c
@@ -102,6 +102,7 @@ static struct s3c24xx_uart_info s3c2412_uart_inf = {
.name = "Samsung S3C2412 UART",
.type = PORT_S3C2412,
.fifosize = 64,
+ .has_divslot = 1,
.rx_fifomask = S3C2440_UFSTAT_RXMASK,
.rx_fifoshift = S3C2440_UFSTAT_RXSHIFT,
.rx_fifofull = S3C2440_UFSTAT_RXFULL,
--
1.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: S3C: Configuration override for UART names
2010-01-27 16:38 [PATCH 1/2] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
@ 2010-01-27 16:38 ` Michel Pollet
2010-01-27 21:34 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Michel Pollet @ 2010-01-27 16:38 UTC (permalink / raw)
To: linux-arm-kernel
S3C UART devices are named s3c2410_serialX and it is
inconsistent with the kernel at boot time (console=ttySACx)
This patch allows the config file to override this and
use the standard name instead.
Signed-off-by: Michel Pollet <buserror@gmail.com>
---
arch/arm/plat-s3c/Kconfig | 9 +++++++++
drivers/serial/samsung.c | 9 ++++++++-
2 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-s3c/Kconfig b/arch/arm/plat-s3c/Kconfig
index 9e9d028..158257a 100644
--- a/arch/arm/plat-s3c/Kconfig
+++ b/arch/arm/plat-s3c/Kconfig
@@ -113,6 +113,15 @@ config S3C_LOWLEVEL_UART_PORT
this configuration should be between zero and two. The port
must have been initialised by the boot-loader before use.
+config S3C_STD_UART_NAMES
+ bool "Name S3C UART device files as ttySACx"
+ default n
+ help
+ The kernel and most other SoC use the ttySACx naming scheme
+ for UART device file naming. The default for S3C is to use
+ s3c2410_serialX, and it confuses a lot of distros; it is also
+ inconsistent with the console= kernel parameter.
+
# options for gpiolib support
config S3C_GPIO_SPACE
diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
index 52e3df1..e3dd135 100644
--- a/drivers/serial/samsung.c
+++ b/drivers/serial/samsung.c
@@ -55,7 +55,14 @@
/* UART name and device definitions */
+#ifdef CONFIG_S3C_STD_UART_NAMES
+/* All other SoC use this naming sheme,
+ including the kernel earlier at boot time */
#define S3C24XX_SERIAL_NAME "ttySAC"
+#else
+/* Legacy option */
+#define S3C24XX_SERIAL_NAME "s3c2410_serial"
+#endif
#define S3C24XX_SERIAL_MAJOR 204
#define S3C24XX_SERIAL_MINOR 64
@@ -878,7 +885,7 @@ static struct uart_ops s3c24xx_serial_ops = {
static struct uart_driver s3c24xx_uart_drv = {
.owner = THIS_MODULE,
- .dev_name = "s3c2410_serial",
+ .dev_name = S3C24XX_SERIAL_NAME,
.nr = CONFIG_SERIAL_SAMSUNG_UARTS,
.cons = S3C24XX_SERIAL_CONSOLE,
.driver_name = S3C24XX_SERIAL_NAME,
--
1.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: S3C: Configuration override for UART names
2010-01-27 16:38 ` [PATCH 2/2] ARM: S3C: Configuration override for UART names Michel Pollet
@ 2010-01-27 21:34 ` Russell King - ARM Linux
0 siblings, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2010-01-27 21:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 04:38:09PM +0000, Michel Pollet wrote:
> diff --git a/arch/arm/plat-s3c/Kconfig b/arch/arm/plat-s3c/Kconfig
> index 9e9d028..158257a 100644
> --- a/arch/arm/plat-s3c/Kconfig
> +++ b/arch/arm/plat-s3c/Kconfig
> @@ -113,6 +113,15 @@ config S3C_LOWLEVEL_UART_PORT
> this configuration should be between zero and two. The port
> must have been initialised by the boot-loader before use.
>
> +config S3C_STD_UART_NAMES
> + bool "Name S3C UART device files as ttySACx"
> + default n
default n is the default default. There's no need to explicitly specify
a default default.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-27 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 16:38 [PATCH 1/2] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
2010-01-27 16:38 ` [PATCH 2/2] ARM: S3C: Configuration override for UART names Michel Pollet
2010-01-27 21:34 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).