public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: Select CPU_32v6K for CPU_V7 only if ARCH_OMAP2 isnot selected
Date: Thu, 28 Jan 2010 18:05:31 +0000	[thread overview]
Message-ID: <1264701931.7064.98.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20100128174741.GN23505@atomide.com>

On Thu, 2010-01-28 at 17:47 +0000, Tony Lindgren wrote:
> * Catalin Marinas <catalin.marinas@arm.com> [100128 02:58]:
> > On Tue, 2010-01-26 at 19:37 +0000, Tony Lindgren wrote:
> > > Otherwise the kernel built with both CPU_V6 and CPU_V7 will not
> > > boot on omap2.
> > >
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > ---
> > >  arch/arm/mm/Kconfig |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> > > index baf6384..4c2e90d 100644
> > > --- a/arch/arm/mm/Kconfig
> > > +++ b/arch/arm/mm/Kconfig
> > > @@ -399,7 +399,7 @@ config CPU_V6
> > >  config CPU_32v6K
> > >         bool "Support ARM V6K processor extensions" if !SMP
> > >         depends on CPU_V6
> > > -       default y if SMP && !ARCH_MX3
> > > +       default y if SMP && !(ARCH_MX3 || ARCH_OMAP2)
> > >         help
> > >           Say Y here if your ARMv6 processor supports the 'K' extension.
> > >           This enables the kernel to use some instructions not present
> > > @@ -410,7 +410,7 @@ config CPU_32v6K
> > >  # ARMv7
> > >  config CPU_V7
> > >         bool "Support ARM V7 processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB || MACH_REALVIEW_PBX
> > > -       select CPU_32v6K
> > > +       select CPU_32v6K if !ARCH_OMAP2
> >
> > I suspect that would be an issue for all ARMv6 platforms without the MP
> > extensions (v6K). Could we do something like:
> >
> >       select CPU_32v6K if SMP || !CPU_V6
> 
> Hmm, but then we can't compile in SMP for single core systems and
> keep it bootable on single core v6?

Not with the current kernel since it hardcodes the shareability bit in
the page tables and the LDREX/STREX operations don't work as expected on
uniprocessor hardware.

I agree that it would be nice to be able to have an SMP kernel booting
on both UP and MP but there are some #ifdef CONFIG_SMP in the kernel
which would need to be sorted out.

-- 
Catalin

  reply	other threads:[~2010-01-28 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 19:37 [PATCH 0/3] Add tmp register for debug-macro.S, do not select CPU_32v6K for omap2 Tony Lindgren
2010-01-26 19:37 ` [PATCH 1/3] ARM: Add tmp register for addruart and loadsp Tony Lindgren
2010-01-26 19:37 ` [PATCH 2/3] ARM: Add tmp register for debug-macro.S files Tony Lindgren
2010-01-26 19:37 ` [PATCH 3/3] ARM: Select CPU_32v6K for CPU_V7 only if ARCH_OMAP2 is not selected Tony Lindgren
2010-01-28 11:00   ` [PATCH 3/3] ARM: Select CPU_32v6K for CPU_V7 only if ARCH_OMAP2 isnot selected Catalin Marinas
2010-01-28 17:47     ` Tony Lindgren
2010-01-28 18:05       ` Catalin Marinas [this message]
2010-01-28 18:33         ` Jamie Lokier
2010-01-29 10:38           ` Catalin Marinas
2010-01-29 10:42       ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264701931.7064.98.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox