[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <eric.y.miao@gmail.com>
Date:   Thu Feb 4 16:41:28 2010 -0800

    input: schedule corgi_ssp and corgi_ts to be removed

    Cc: Richard Purdie <rpurdie@rpsys.net>
    Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

diff --git a/Documentation/feature-removal-schedule.txt
b/Documentation/feature-removal-schedule.txt
index 5860583..e16529e 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
keyboard driver that
 	and so are difficult to maintain.
 Who:	Eric Miao <eric.y.miao@gmail.com>

+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that to wait til vsync before ADC sampling is also inte grated into
+	ads7846 driver now. Provided that the original driver is no generic
+	and difficult to maintain, will be removed later.
+Who:	Eric Miao <eric.y.miao@gmail.com>
+

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Uwe Kleine-König]

Hi Eric,

> diff --git a/Documentation/feature-removal-schedule.txt
> b/Documentation/feature-removal-schedule.txt
> index 5860583..e16529e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
> keyboard driver that
>  	and so are difficult to maintain.
>  Who:	Eric Miao <eric.y.miao@gmail.com>
> 
> +----------------------------
> +
> +What:	corgi_ssp and corgi_ts driver
> +When:	2.6.35
> +Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
> +Why:	The corgi touchscreen is now deprecated in favour of the generic
> +	ads7846.c driver. The noise reduction technique used in corgi_ts.c
> +	that to wait til vsync before ADC sampling is also inte grated into
> +	ads7846 driver now. Provided that the original driver is no generic
s/no /not / or s/is no/isn't/

Best regards
Uwe

> +	and difficult to maintain, will be removed later.
> +Who:	Eric Miao <eric.y.miao@gmail.com>
> +

-- 
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Sergei Shtylyov]

Hello.

Eric Miao wrote:

> commit 31cec413e534520111716802833675f53ac99b0b
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date:   Thu Feb 4 16:41:28 2010 -0800
>
>     input: schedule corgi_ssp and corgi_ts to be removed
>
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>   

   Some grammar nitpicking...

> diff --git a/Documentation/feature-removal-schedule.txt
> b/Documentation/feature-removal-schedule.txt
> index 5860583..e16529e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix
> keyboard driver that
>  	and so are difficult to maintain.
>  Who:	Eric Miao <eric.y.miao@gmail.com>
>
> +----------------------------
> +
> +What:	corgi_ssp and corgi_ts driver
> +When:	2.6.35
> +Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
> +Why:	The corgi touchscreen is now deprecated in favour of the generic
> +	ads7846.c driver. The noise reduction technique used in corgi_ts.c
> +	that to wait til vsync before ADC sampling is also

   that's?


>  inte grated into
>   

    integrated.

> +	ads7846 driver now. Provided that the original driver is no generic
>   

   not generic

> +	and difficult to maintain, will be removed later.
>   

   it will.

> +Who:	Eric Miao <eric.y.miao@gmail.com>
> +
>   

WBR, Sergei

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

>>
>
> ?Some grammar nitpicking...
>

Grrr.... anyone has a good recommendation of English training institute
for me? :-)

Patch updated as below:

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Richard Purdie]

On Fri, 2010-02-05 at 03:04 -0800, Eric Miao wrote:
> From 31cec413e534520111716802833675f53ac99b0b Mon Sep 17 00:00:00 2001
> From: Eric Miao <eric.y.miao@gmail.com>
> Date: Thu, 4 Feb 2010 16:41:28 -0800
> Subject: [PATCH 13/13] input: schedule corgi_ssp and corgi_ts to be removed
> 
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

Acked-by: Richard Purdie <rpurdie@rpsys.net>

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Pavel Machek]

On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> commit 31cec413e534520111716802833675f53ac99b0b
> Author: Eric Miao <eric.y.miao@gmail.com>
> Date:   Thu Feb 4 16:41:28 2010 -0800
> 
>     input: schedule corgi_ssp and corgi_ts to be removed
> 
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>

ACK.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>> commit 31cec413e534520111716802833675f53ac99b0b
>> Author: Eric Miao <eric.y.miao@gmail.com>
>> Date: ? Thu Feb 4 16:41:28 2010 -0800
>>
>> ? ? input: schedule corgi_ssp and corgi_ts to be removed
>>
>> ? ? Cc: Richard Purdie <rpurdie@rpsys.net>
>> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>
> ACK.
>

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Dmitry Torokhov]

On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> >> commit 31cec413e534520111716802833675f53ac99b0b
> >> Author: Eric Miao <eric.y.miao@gmail.com>
> >> Date: ? Thu Feb 4 16:41:28 2010 -0800
> >>
> >> ? ? input: schedule corgi_ssp and corgi_ts to be removed
> >>
> >> ? ? Cc: Richard Purdie <rpurdie@rpsys.net>
> >> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >
> > ACK.
> >
> 
> Thanks, guys.
> 
> Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

-- 
Dmitry

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>> >> commit 31cec413e534520111716802833675f53ac99b0b
>> >> Author: Eric Miao <eric.y.miao@gmail.com>
>> >> Date: ? Thu Feb 4 16:41:28 2010 -0800
>> >>
>> >> ? ? input: schedule corgi_ssp and corgi_ts to be removed
>> >>
>> >> ? ? Cc: Richard Purdie <rpurdie@rpsys.net>
>> >> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> >
>> > ACK.
>> >
>>
>> Thanks, guys.
>>
>> Dmitry, I'm hoping these two patches will go through your tree please?
>
> I have it in next, do you want it in .33 instead?
>

No. -next is good, thanks man.

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

On Tue, Feb 9, 2010 at 8:23 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
>>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
>>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
>>> >> commit 31cec413e534520111716802833675f53ac99b0b
>>> >> Author: Eric Miao <eric.y.miao@gmail.com>
>>> >> Date: ? Thu Feb 4 16:41:28 2010 -0800
>>> >>
>>> >> ? ? input: schedule corgi_ssp and corgi_ts to be removed
>>> >>
>>> >> ? ? Cc: Richard Purdie <rpurdie@rpsys.net>
>>> >> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>>> >
>>> > ACK.
>>> >
>>>
>>> Thanks, guys.
>>>
>>> Dmitry, I'm hoping these two patches will go through your tree please?
>>
>> I have it in next, do you want it in .33 instead?
>>
>
> No. -next is good, thanks man.
>

Dmitry,

Attached are the two patches updated, with Pavel's suggestion to make them
default to 'n' and with their Acks. Please consider re-apply, sorry for the
bother.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-input-mark-corgi-spitz-tosa-kbd-driver-deprecated.patch
Type: text/x-patch
Size: 3424 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100209/95484599/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-input-schedule-corgi_ssp-and-corgi_ts-to-be-removed.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100209/95484599/attachment-0001.bin>

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Dmitry Torokhov]

On Tue, Feb 09, 2010 at 08:33:49PM +0800, Eric Miao wrote:
> On Tue, Feb 9, 2010 at 8:23 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> > On Tue, Feb 9, 2010 at 5:09 PM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> >> On Tue, Feb 09, 2010 at 09:15:38AM +0800, Eric Miao wrote:
> >>> On Tue, Feb 9, 2010 at 2:06 AM, Pavel Machek <pavel@ucw.cz> wrote:
> >>> > On Thu 2010-02-04 16:45:41, Eric Miao wrote:
> >>> >> commit 31cec413e534520111716802833675f53ac99b0b
> >>> >> Author: Eric Miao <eric.y.miao@gmail.com>
> >>> >> Date: ? Thu Feb 4 16:41:28 2010 -0800
> >>> >>
> >>> >> ? ? input: schedule corgi_ssp and corgi_ts to be removed
> >>> >>
> >>> >> ? ? Cc: Richard Purdie <rpurdie@rpsys.net>
> >>> >> ? ? Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >>> >
> >>> > ACK.
> >>> >
> >>>
> >>> Thanks, guys.
> >>>
> >>> Dmitry, I'm hoping these two patches will go through your tree please?
> >>
> >> I have it in next, do you want it in .33 instead?
> >>
> >
> > No. -next is good, thanks man.
> >
> 
> Dmitry,
> 
> Attached are the two patches updated, with Pavel's suggestion to make them
> default to 'n' and with their Acks. Please consider re-apply, sorry for the
> bother.

Re-applied (with just removing 'default y' instead of replacing with
'default n' which is the same thing).

Thanks.

-- 
Dmitry

[PATCH] input: schedule corgi_ssp and corgi_ts to be removed

[Eric Miao]

> Re-applied (with just removing 'default y' instead of replacing with
> 'default n' which is the same thing).
>

Ah, yes, that's much cleaner. Thanks Dmitry.