From: alberto.panizzo@gmail.com (Alberto Panizzo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MXC: mach_armadillo5x0: Add USB Host support.
Date: Thu, 25 Feb 2010 10:31:29 +0100 [thread overview]
Message-ID: <1267090289.2722.4.camel@realization> (raw)
In-Reply-To: <20100225080259.GA13295@pengutronix.de>
Hi Uwe,
On gio, 2010-02-25 at 09:02 +0100, Uwe Kleine-K?nig wrote:
> Hi Alberto,
>
> On Thu, Feb 25, 2010 at 12:27:12AM +0100, Alberto Panizzo wrote:
> > This add USB Host capability. The Armadillo 500 board is supplied
> > with two USB Host connectors driven by the USB OTG and USB Host 2
> > ports, through two NXP isp 1504 transceivers.
> >
> > Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
> > ---
> >
> > Sascha, if there aren't problems, can you add this for 2.6.34?
> >
..
> > #include "crm_regs.h"
> > @@ -103,6 +108,118 @@ static int armadillo5x0_pins[] = {
> > /* I2C2 */
> > MX31_PIN_CSPI2_MOSI__SCL,
> > MX31_PIN_CSPI2_MISO__SDA,
> > + /* OTG */
> > + MX31_PIN_USBOTG_DATA0__USBOTG_DATA0,
> > + MX31_PIN_USBOTG_DATA1__USBOTG_DATA1,
> > + MX31_PIN_USBOTG_DATA2__USBOTG_DATA2,
> > + MX31_PIN_USBOTG_DATA3__USBOTG_DATA3,
> > + MX31_PIN_USBOTG_DATA4__USBOTG_DATA4,
> > + MX31_PIN_USBOTG_DATA5__USBOTG_DATA5,
> > + MX31_PIN_USBOTG_DATA6__USBOTG_DATA6,
> > + MX31_PIN_USBOTG_DATA7__USBOTG_DATA7,
> > + MX31_PIN_USBOTG_CLK__USBOTG_CLK,
> > + MX31_PIN_USBOTG_DIR__USBOTG_DIR,
> > + MX31_PIN_USBOTG_NXT__USBOTG_NXT,
> > + MX31_PIN_USBOTG_STP__USBOTG_STP,
> > + /* USB host 2 */
> > + IOMUX_MODE(MX31_PIN_USBH2_CLK, IOMUX_CONFIG_FUNC),
> > + IOMUX_MODE(MX31_PIN_USBH2_DIR, IOMUX_CONFIG_FUNC),
> > ...
> I think you need to protect all hunks by
> #ifdef CONFIG_USB_ULPI
>
> For the pin-setup it's not important, but you must not call
> otg_ulpi_create if USB_ULPI isn't configured.
>
> Best regards
> Uwe
>
Ok, I'd seen this protection in pcm037 but I thought that on
my board USB will be always enabled.
Sascha, please throw this patch, The From: mail is wrong, sorry..
Alberto!
next prev parent reply other threads:[~2010-02-25 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 23:27 [PATCH] MXC: mach_armadillo5x0: Add USB Host support Alberto Panizzo
2010-02-25 8:02 ` Uwe Kleine-König
2010-02-25 9:31 ` Alberto Panizzo [this message]
2010-02-25 9:35 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267090289.2722.4.camel@realization \
--to=alberto.panizzo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).