From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] i.MX: system.c: Convert goto to if statement
Date: Mon, 13 Jun 2016 11:24:16 +0200 [thread overview]
Message-ID: <12670937.kESCsuxMaL@wuerfel> (raw)
In-Reply-To: <1465797329-22537-1-git-send-email-andrew.smirnov@gmail.com>
On Sunday, June 12, 2016 10:55:27 PM CEST Andrey Smirnov wrote:
> Using goto here doesn't bring any advantages and only makes the code
> flow less clear. No functional changes.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
All three patches looks reasonable to me, but now that I looked at
the function, I wonder if we could do another cleanup on top and
not call this function for imx35 at all but instead set the
.l2c_aux_val/.l2c_aux_mask fields in its machine descriptor.
The call to l2x0_of_init(0, ~0) seems to be the only thing we
do on imx35 (where arm,pl310-cache is not present), and the kernel
can do it automatically.
Arnd
next prev parent reply other threads:[~2016-06-13 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 5:55 [PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-13 5:55 ` [RESEND PATCH 2/3] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov
2016-06-13 5:55 ` [PATCH 3/3] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-13 9:24 ` Arnd Bergmann
2016-06-13 9:41 ` Russell King - ARM Linux
2016-06-13 9:28 ` Russell King - ARM Linux
2016-06-13 9:24 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-07 15:29 [PATCH 1/3] i.MX: system.c: Convert goto to if statement Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12670937.kESCsuxMaL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox