From mboxrd@z Thu Jan 1 00:00:00 1970 From: chripell@fsfe.org (Christian Pellegrin) Date: Fri, 12 Mar 2010 08:29:03 +0100 Subject: [PATCH v2] Fix one-too-much bug when building list of regs to be preserved on PM In-Reply-To: References: Message-ID: <1268378943-7924-1-git-send-email-chripell@fsfe.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org gpio_nr is already incremented in the for loop, so if we will have 32 banks of GPIOs someday the 33rd won't be saved/restored during PM Signed-off-by: Christian Pellegrin --- arch/arm/plat-s3c/pm-gpio.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-s3c/pm-gpio.c b/arch/arm/plat-s3c/pm-gpio.c index cfd326a..b3cc8db 100644 --- a/arch/arm/plat-s3c/pm-gpio.c +++ b/arch/arm/plat-s3c/pm-gpio.c @@ -343,7 +343,7 @@ void s3c_pm_save_gpios(void) ourchip->pm_save[2], ourchip->pm_save[3]); - gpio_nr += ourchip->chip.ngpio; + gpio_nr += ourchip->chip.ngpio - 1; gpio_nr += CONFIG_S3C_GPIO_SPACE; } } @@ -374,7 +374,7 @@ void s3c_pm_restore_gpios(void) s3c_pm_resume_gpio(ourchip); - gpio_nr += ourchip->chip.ngpio; + gpio_nr += ourchip->chip.ngpio - 1; gpio_nr += CONFIG_S3C_GPIO_SPACE; } } -- 1.5.6.5