From: vzapolskiy@gmail.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] [ARM] [IMX]: Fix clock usecount counter from underflow.
Date: Wed, 17 Mar 2010 10:11:56 +0300 [thread overview]
Message-ID: <1268809916-6525-2-git-send-email-vzapolskiy@gmail.com> (raw)
In-Reply-To: <1268809916-6525-1-git-send-email-vzapolskiy@gmail.com>
If clk_disable() is called for already disabled clock clk->usecount
value is decremented anyway. This leads to a problem that sequent
clk_enable() call doesn't enable the clock as expected.
Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
arch/arm/plat-mxc/clock.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-mxc/clock.c b/arch/arm/plat-mxc/clock.c
index 2daec3c..fd7596c 100644
--- a/arch/arm/plat-mxc/clock.c
+++ b/arch/arm/plat-mxc/clock.c
@@ -53,10 +53,15 @@ static void __clk_disable(struct clk *clk)
if (clk == NULL || IS_ERR(clk))
return;
+ if (!clk->usecount) {
+ printk(KERN_ERR "Trying to disable a clock with 0 usecount\n");
+ WARN_ON(1);
+ return;
+ }
+
__clk_disable(clk->parent);
__clk_disable(clk->secondary);
- WARN_ON(!clk->usecount);
if (!(--clk->usecount) && clk->disable)
clk->disable(clk);
}
--
1.6.6.1
next prev parent reply other threads:[~2010-03-17 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 7:11 [PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity Vladimir Zapolskiy
2010-03-17 7:11 ` Vladimir Zapolskiy [this message]
2010-03-17 9:20 ` [PATCH 2/2] [ARM] [IMX]: Fix clock usecount counter from underflow Uwe Kleine-König
2010-03-17 10:15 ` javier Martin
2010-03-17 10:57 ` Vladimir Zapolskiy
2010-03-17 11:03 ` [PATCH 2/2 v2] [ARM] [IMX]: Fix clock use counter from underflow on multiple clk_disable() Vladimir Zapolskiy
2010-03-18 8:30 ` Uwe Kleine-König
2010-03-18 13:21 ` Vladimir Zapolskiy
2010-03-17 9:13 ` [PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity Uwe Kleine-König
2010-03-17 10:34 ` Vladimir Zapolskiy
2010-03-18 8:37 ` Uwe Kleine-König
2010-03-18 13:07 ` Vladimir Zapolskiy
2010-03-18 13:27 ` [PATCH 1/2 v2] imx: optimize __clk_enable() and __clk_disable() functions Vladimir Zapolskiy
2010-03-18 14:23 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268809916-6525-2-git-send-email-vzapolskiy@gmail.com \
--to=vzapolskiy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).