From: gores@marvell.com (Siddarth Gore)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Kirkwood: Marvell GuruPlug support
Date: Tue, 23 Mar 2010 18:13:23 +0530 [thread overview]
Message-ID: <1269348203.23313.198.camel@pe-dt434> (raw)
In-Reply-To: <i13k77-9sp.ln1@chipmunk.wormnet.eu>
On Mon, 2010-03-22 at 05:05 -0700, Alexander Clouter wrote:
> Siddarth Gore <gores@marvell.com> wrote:
> >
> > GuruPlug Standard: 1 Gb Ethernet, 2 USB 2.0
> > GuruPlug Plus: 2 Gb Ethernet, 2 USB 2.0, 1 eSATA, 1 uSD slot
> >
> > References:
> > http://www.globalscaletechnologies.com/t-guruplugdetails.aspx
> > http://plugcomputer.org
> >
> > This patch is for GuruPlug Plus, but it supports Standard version
> > as well.
> >
> > Signed-off-by: Siddarth Gore <gores@marvell.com>
> > ---
> > arch/arm/mach-kirkwood/Kconfig | 6 ++
> > arch/arm/mach-kirkwood/Makefile | 1 +
> > arch/arm/mach-kirkwood/guruplug-setup.c | 131 +++++++++++++++++++++++++++++++
> > 3 files changed, 138 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-kirkwood/guruplug-setup.c
> >
> > diff --git a/arch/arm/mach-kirkwood/guruplug-setup.c b/arch/arm/mach-kirkwood/guruplug-setup.c
> > new file mode 100644
> > index 0000000..54d07c8
> > --- /dev/null
> > +++ b/arch/arm/mach-kirkwood/guruplug-setup.c
> > @@ -0,0 +1,131 @@
> >
> Any harm in merging this into the sheevaplug-setup code, like the openrd
> code?
>
> http://git.marvell.com/?p=orion.git;a=commit;h=b2fdb5660fccc060e47658baad8911a963397ced
>
No harm as such. but i think having separate setup files will be a
cleaner approach, instead of adding more if(machine_is_<>) statements.
Looks like openrd base/client are same boards with client having an
extra ethernet port. sheevaplug and guruplug are two different boards
(pcb's) having different gpio settings, peripherals, etc.
-siddarth
> Cheers
>
next prev parent reply other threads:[~2010-03-23 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 9:28 [PATCH] Kirkwood: Marvell GuruPlug support Siddarth Gore
2010-03-22 12:05 ` Alexander Clouter
2010-03-23 12:43 ` Siddarth Gore [this message]
2010-03-23 13:23 ` Alexander Clouter
2010-03-23 16:48 ` Nicolas Pitre
2010-03-23 18:35 ` Alexander Clouter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269348203.23313.198.camel@pe-dt434 \
--to=gores@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox