linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: AACI broken with commit 29a4f2d3
Date: Fri, 26 Mar 2010 14:12:14 +0000	[thread overview]
Message-ID: <1269612734.807.73.camel@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20100326140833.GK27692@sirena.org.uk>

On Fri, 2010-03-26 at 14:08 +0000, Mark Brown wrote:
> On Fri, Mar 26, 2010 at 01:54:45PM +0000, Catalin Marinas wrote:
> 
> > But the above says "the power down control and status register (0x26) of
> > the CODEC". So this refers to the AC97 registers rather than the AACI
> > registers. Your patch reads from the AACI registers. The AC97 registers
> > I think are access with aaci_ac97_(read|write) functions.
> 
> Yes, they are - but note that some CODECs will power up in low power
> mode and therefore attempts to read immediately after the controller
> probe function starts executing may fail until the controller has issued
> a warm reset.

Yes, possibly. But my point is that accessing offset 0x26 in the AACI
register space has nothing to do with the AC97 power register. At offset
0x26 in the AACI register space you find the top part of the AACIIE2
register (if you can even read this as a half-word).

-- 
Catalin

  reply	other threads:[~2010-03-26 14:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 13:51 AACI broken with commit 29a4f2d3 Catalin Marinas
2010-03-24 15:10 ` Catalin Marinas
2010-03-24 15:18   ` Will Deacon
2010-03-25 11:12     ` Takashi Iwai
2010-03-25 11:30       ` Russell King - ARM Linux
2010-03-25 11:36         ` Takashi Iwai
2010-03-25 11:50           ` Philby John
2010-03-25 12:02             ` Catalin Marinas
2010-03-25 12:16               ` Russell King - ARM Linux
2010-03-26 11:28                 ` Philby John
2010-03-26 13:00                   ` Catalin Marinas
2010-03-26 13:10                     ` Philby John
2010-03-26 13:24                       ` Mark Brown
2010-03-26 13:54                       ` Catalin Marinas
2010-03-26 14:00                         ` Philby John
2010-03-26 14:05                           ` Catalin Marinas
2010-03-26 14:08                         ` Mark Brown
2010-03-26 14:12                           ` Catalin Marinas [this message]
2010-03-26 14:15                             ` Mark Brown
2010-03-26 16:07                             ` Philby John
2010-03-26 21:11                               ` Takashi Iwai
2010-03-29  7:45                                 ` Philby John
2010-03-29  7:57                                   ` Takashi Iwai
2010-04-06  8:12                                     ` Takashi Iwai
2010-04-06 17:41                                       ` Russell King - ARM Linux
2010-04-06 18:07                                         ` Takashi Iwai
2010-04-12 18:31                                           ` Russell King - ARM Linux
2010-04-13  7:48                                             ` Takashi Iwai
2010-03-26 22:56                     ` Russell King - ARM Linux
2010-03-26 18:15                   ` Russell King - ARM Linux
2010-03-25 12:06             ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269612734.807.73.camel@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).