From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEFDEC83F03 for ; Fri, 4 Jul 2025 14:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ya7olpWaKo7EvJdDI1FNJDoi/Pi3mNyOZPA0TG9VvQU=; b=Fx5zpMxPvEBi+UfLhvzUsdevzS TvLiqG1EyMhahU6PtsXOYoqCrH+xoIH1ZVHcz8dds5Ee4YOy3JTzmNaUAvSKALq/bm0jhHdfdh29P hQKx9ceWetvbZXilkaG9Wu9v8ZGwhYo1mxRVOapCawXFkv4L4n53nJBY7j4q5AW1zPun6JT7gZU61 MjxYbr5+toSYPU5I6LOuJvY/apd9U2pTnFtiZW0o3eheEv/Xyd+9PeqHRiEM5RkU0GHCQdxQ4Fv0O iSPT0Rgq2s6/fAIdS+FgDZgBiq6qF3KR8OLaSmPfgQw9ip2BtQ26yWeaGiSEoxGke0H3NIkZQHtnO /VMHpjbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXhD8-0000000Ee08-3Tft; Fri, 04 Jul 2025 14:16:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXguq-0000000EawU-1fZK for linux-arm-kernel@lists.infradead.org; Fri, 04 Jul 2025 13:57:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751637443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ya7olpWaKo7EvJdDI1FNJDoi/Pi3mNyOZPA0TG9VvQU=; b=Xwdd3Q4gRvMroq7b/7o1Xjd0CfVYJLG0TcEcifnYiGCJpZKTeM34+ZO0wLHePsxqUeB89+ Xm73ziZ5L2kpd5PBVKUI4W022a0+lBhirUbCDNTvmsA1RDgE9AzRbnIyYSVVrMycU1dtPF TO4U3zpff0TG1KiYBhk/yeHjhwrNnMA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-WEl7jL1fMj62BydqSvjldw-1; Fri, 04 Jul 2025 09:57:22 -0400 X-MC-Unique: WEl7jL1fMj62BydqSvjldw-1 X-Mimecast-MFC-AGG-ID: WEl7jL1fMj62BydqSvjldw_1751637441 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a50816ccc6so627754f8f.1 for ; Fri, 04 Jul 2025 06:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751637441; x=1752242241; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ya7olpWaKo7EvJdDI1FNJDoi/Pi3mNyOZPA0TG9VvQU=; b=VjIexp1+zGRwCfbOqqv67al/rBCd9GTbx5q626qG4k5puHmqC4LEF0WH+qQ2dQM3hZ +CX58aIYmEa55sy7gUVCieFUk9cxcWuGORRekkDQ5suJ67LrpWIzPFQ9pRLdqWpIQ4sS UCBsSa9+Eh9mmC9kTkiBvTdeV5LymP6uCu1+8m/Sk7vbt9VcRloZtWyYUyA9tReV5Vkx /tND4iDmOC/MM12gnw2rUDEHrI3oN77NkYg4wrZPoUPxaaQEt01dWjY7xRNooe+fccga /0a6/JuvrlkFQpP0mYi0I1d/453Ft+E8WXFIxoeLKnF1uvlY4k+3b5jnpgazsaIa5vLZ X+rQ== X-Forwarded-Encrypted: i=1; AJvYcCUg8cl7aaitt+YDTL3Nla+j4iXoErvaYbDM9bl6eA5bk8Jg8cKSF7mtXNRl64j+ZfQBultrexzLYXazo8dVKh5E@lists.infradead.org X-Gm-Message-State: AOJu0YymsU9y2VYS1+CAF9F/vk7nK4r3kHG3yNRvkUCqjPrpCUfpw+yi BhPKppCAgSBVGHQSBRJX9eMw2SjfJjw4IjMp7JV/MKbGOvpwN3KCo2bZTEVwWESwYvMB0ijv505 FKJ1MPM3YtD/4Shp6rUoMSthhswzfN34YFZoYUA6AIcUVz8/1RIrzx/ljCOMNrCjPvH3qoxAOoO hw X-Gm-Gg: ASbGncv7mDf9h5MAORjUl85TuDkurnP4d35nxuYnaFxLXbPrVu3DUYRwTeSlDmydPMC fS6J8caaTM+mo0gM8uCw5/H+GUUOt1ZeKXU5/4ZiFf61hjfIig42CqzThh1QHjTvIfHLLEE1TvY SdRB0x1DwTG76HBK4AyQl7oEW9X28fHZNaOi/sSpxh0szbjpatKZ0otV6BH2GE2CDtx0Nm6xPKM uSwIJBUQBJe5aqUKbsTaNbNDspQY3mhX7y1L7U/kcFyEQ1gFdVya3LLM6whRsVdTHvHdB/i7G5D ahPRfORpdLLwCMoQIGbmSKANs7qu44gr5DlhdPAZmn0PI4N0LWi4eyvPNxhpsXiPAPlhfoLr96u jyqG1FCGTl86ws4R8FRu+b5DRPdO1Xx1/d1uPZM53Ux/WAnM= X-Received: by 2002:a05:6000:400b:b0:3ab:27f9:e4f with SMTP id ffacd0b85a97d-3b497031623mr2343019f8f.35.1751637440574; Fri, 04 Jul 2025 06:57:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQ6/2pQFMrT6QRPXJE31trAIEXkKng/iYOe8KKbT5kWjkE1JQQmcpiHONJbWK/qwqZ2Sobdg== X-Received: by 2002:a05:6000:400b:b0:3ab:27f9:e4f with SMTP id ffacd0b85a97d-3b497031623mr2342968f8f.35.1751637440058; Fri, 04 Jul 2025 06:57:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47285dda7sm2614728f8f.99.2025.07.04.06.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 06:57:19 -0700 (PDT) Message-ID: <126f839c-f0e5-42a4-a172-2cefd59e5750@redhat.com> Date: Fri, 4 Jul 2025 15:57:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/6] KVM: arm64: Rename the device variable to s2_force_noncacheable To: ankita@nvidia.com, jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, ddutile@redhat.com, seanjc@google.com Cc: aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn References: <20250621042111.3992-1-ankita@nvidia.com> <20250621042111.3992-2-ankita@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250621042111.3992-2-ankita@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: baS7HSk8MJ8My4ueGY6DIUWIbxWo5hZxU81-irrGi1o_1751637441 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250704_065724_521365_B4150AE3 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.06.25 06:21, ankita@nvidia.com wrote: > From: Ankit Agrawal > > For cache maintenance on a region, ARM KVM relies on that > region to be mapped to the Kernal virtual address as CMOs > operate on VA. > > Currently the device variable is effectively trying to setup > the S2 mapping as non cacheable for memory regions that are > not mapped in the Kernel VA. This could be either device or > Normal_NC depending on the VM_ALLOW_ANY_UNCACHED flag in the > VMA. > > Thus "device" could be better renamed to s2_force_noncacheable > which implies that it is ensuring that region be mapped as > non-cacheable. > > CC: Catalin Marinas > Suggested-by: Jason Gunthorpe > Signed-off-by: Ankit Agrawal > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb