From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: orion5x and GPIO blink question
Date: Thu, 22 Apr 2010 07:09:57 +1000 [thread overview]
Message-ID: <1271884197.2330.158.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.1004211020010.7232@xanadu.home>
On Wed, 2010-04-21 at 10:29 -0400, Nicolas Pitre wrote:
> > Another solution might be to be a bit smarter and have leds-gpio
> > implement a different set_blink() function that takes an additional
> > enable/disable argument, and would call that whenever set_brightness is
> > called on a currently blinking GPIO.
> >
> > But that means fixing all the in-tree users of leds-gpio set_blink()
> > callback (I haven't counted, but it should be easily greppable).
> >
> > Opinions ?
>
> I always have a preference for fixing things properly. And with a quick
> grep there seems to be very few set_blink in the whole tree.
Ok, fair enough. I'll give that a go later, maybe next week, as time
permits.
Cheers,
Ben.
next prev parent reply other threads:[~2010-04-21 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 7:57 orion5x and GPIO blink question Benjamin Herrenschmidt
2010-04-21 14:29 ` Nicolas Pitre
2010-04-21 21:09 ` Benjamin Herrenschmidt [this message]
2010-04-21 17:21 ` Richard Purdie
2010-04-21 21:31 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271884197.2330.158.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).