From mboxrd@z Thu Jan 1 00:00:00 1970 From: gores@marvell.com (Siddarth Gore) Date: Mon, 10 May 2010 10:13:29 +0530 Subject: adding pxa3xx_nand_flash to platform data In-Reply-To: References: <1273046285.29563.311.camel@pe-dt434> Message-ID: <1273466610.6926.5.camel@pe-dt434> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2010-05-06 at 02:20 -0700, Haojian Zhuang wrote: > On Wed, May 5, 2010 at 4:56 AM, Eric Miao wrote: > > On Wed, May 5, 2010 at 4:56 PM, Eric Miao wrote: > >> On Wed, May 5, 2010 at 3:58 PM, Siddarth Gore wrote: > >>> Hello Eric, > >>> > >>> Currently I need to enable the deprecated MTD_NAND_PXA3xx_BUILTIN > >>> support for Aspenite DB board (pxa168). I have a patch ready to add > >>> pxa3xx_nand_flash in aspenite.c but I was wondering about the cmdset > >>> field in it. > >>> Looks like it is the same for all boards (depending upon the page size). > >>> So should I add it to the board specific setup file or remove it from > >>> pxa3xx_nand_platform_data (and put it in say, pxa3xx_nand_info)? > >>> > >>> If there are boards which require a different cmdset then we have to go > >>> with first option, if not, we can use option two and save some code > >>> duplication. > >>> > >> > >> There are normally two sets of commands, yet the code derived from some > >> previous work that there were several subtle different command sets. > >> > > We already formated the patches of removing the duplication. Now it's > put into mailist. Try these patches. > Thanks a lot Haojian. I have tried the whole patchset and it is working fine on my Aspenite DB board. Did not get a chance to check individual patches though. Also, some patches did not get applied with git-am. I had to manually apply them. -siddarth > Thanks > Haojian