linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tomi.valkeinen@nokia.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] Initial attempt to make ARM use LMB
Date: Mon, 17 May 2010 13:26:18 +0300	[thread overview]
Message-ID: <1274091978.2307.49.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <20100517094421.GG23118@n2100.arm.linux.org.uk>

Hi,

On Mon, 2010-05-17 at 11:44 +0200, ext Russell King - ARM Linux wrote:
> On Mon, May 17, 2010 at 12:38:55PM +0300, Grazvydas Ignotas wrote:
> > On Fri, May 14, 2010 at 1:16 PM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> > >> because it also uses reserve_bootmem() in
> > >> drivers/video/omap2/vram.c and later ioremap on RAM. Perhaps LMB can
> > >> be used to fix that too?
> > >
> > > WTF is reserve_bootmem doing in a driver?
> > 
> > IIRC Tony refused any new fb related code in arch/arm/*omap* so it
> > ended up there (or maybe because of something else, not that I had
> > anything to do with this).
> 
> Can someone please answer these questions:
> 
> 1. why does the framebuffer need to _reserve_ a set of specific sections
>    of SDRAM rather than _allocate_ a set of sections?
> 2. what range of sizes of SDRAM does the framebuffer driver need?

Yep, vram.c was first located in arch/arm/plat-omap/ but was moved under
drivers/video/omap2 by request from Tony. vram.c is not really a driver,
so in that sense I think it'd fit better into arch/arm/plat-omap/.

To question 1:

- The bootloader may use a certain area of memory to display to boot
image, and the kernel needs to use this same memory area for the
framebuffer, so that we don't get any glitches on the display during
boot. If this is not required, then the memory areas can be allocated.

- OMAP display hardware requires a continuous memory area for the
framebuffer. Allocating such a large continuous memory area later seemed
to be next to impossible, probably because of memory fragmentation.

- Originally I used dma_alloc_*, but that doesn't support the
bootloader-init case, and I also wanted to support having the
framebuffer in OMAP's SRAM. Also, if I recall right, dma_alloc_* didn't
support the huge allocations that are needed for the framebuffer.

To 2:
It varies a lot on the use case. One can configure the reserved VRAM
area, and I would imagine that the smallest would be something like
~150kB (320x240x2) and the largest in extreme case ~40MB (1600x1200*4,
x2 for double buffering and x3 for each overlay).

 Tomi

  reply	other threads:[~2010-05-17 10:26 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 23:32 [RFC] Initial attempt to make ARM use LMB Russell King - ARM Linux
2010-03-31  6:43 ` Jeremy Kerr
2010-04-01  9:47   ` Tony Lindgren
2010-04-09 11:13   ` Russell King - ARM Linux
2010-04-08 15:32 ` Rabin Vincent
2010-04-08 18:27   ` Russell King - ARM Linux
2010-04-09 11:11     ` Russell King - ARM Linux
2010-04-10  3:42       ` Rabin Vincent
2010-04-10  7:03         ` Russell King - ARM Linux
2010-04-10 11:56           ` Rabin Vincent
2010-04-14  7:34       ` Benjamin Herrenschmidt
2010-05-05 15:02 ` Russell King - ARM Linux
2010-05-13 17:40   ` Russell King - ARM Linux
2010-05-13 21:19     ` Tony Lindgren
2010-05-13 21:58       ` Russell King - ARM Linux
2010-05-13 22:01         ` Tony Lindgren
2010-05-13 22:12           ` Russell King - ARM Linux
2010-05-14  7:24             ` Shilimkar, Santosh
2010-05-14 10:11               ` Grazvydas Ignotas
2010-05-14 10:16                 ` Russell King - ARM Linux
2010-05-17  9:38                   ` Grazvydas Ignotas
2010-05-17  9:44                     ` Russell King - ARM Linux
2010-05-17 10:26                       ` Tomi Valkeinen [this message]
2010-05-17 17:37                         ` Tony Lindgren
2010-05-18  7:47                           ` Tomi Valkeinen
2010-05-18  8:40                             ` Russell King - ARM Linux
2010-05-18  8:58                               ` Tomi Valkeinen
2010-05-14 15:22             ` Tony Lindgren
2010-05-14 15:32               ` Shilimkar, Santosh
2010-05-14 15:43                 ` Tony Lindgren
2010-05-22 21:58 ` Russell King - ARM Linux
2010-05-26  0:44   ` Tony Lindgren
2010-05-26  7:50     ` Russell King - ARM Linux
2010-05-26 13:51       ` Tony Lindgren
2010-05-26 21:40         ` Russell King - ARM Linux
2010-05-27  8:52           ` Tomi Valkeinen
2010-05-27  9:25             ` Russell King - ARM Linux
2010-05-27  9:47               ` Tomi Valkeinen
2010-05-28 14:32     ` Russell King - ARM Linux
2010-05-31  8:04       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274091978.2307.49.camel@tubuntu.research.nokia.com \
    --to=tomi.valkeinen@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).