From: andrea.gelmini@gelma.net (Andrea Gelmini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 138/199] arch/arm/mach-shark/pci.c: Checkpatch cleanup
Date: Sun, 23 May 2010 21:55:47 +0200 [thread overview]
Message-ID: <1274644549-24952-11-git-send-email-andrea.gelmini@gelma.net> (raw)
In-Reply-To: <1274644549-24952-1-git-send-email-andrea.gelmini@gelma.net>
arch/arm/mach-shark/pci.c:19: ERROR: trailing statements should be on next line
arch/arm/mach-shark/pci.c:20: ERROR: trailing statements should be on next line
arch/arm/mach-shark/pci.c:21: ERROR: trailing statements should be on next line
arch/arm/mach-shark/pci.c:24: WARNING: externs should be avoided in .c files
arch/arm/mach-shark/pci.c:28: WARNING: please, no space before tabs
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-shark/pci.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c
index 37a7112..89d175c 100644
--- a/arch/arm/mach-shark/pci.c
+++ b/arch/arm/mach-shark/pci.c
@@ -16,16 +16,19 @@
static int __init shark_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
{
if (dev->bus->number == 0)
- if (dev->devfn == 0) return 255;
- else return 11;
- else return 255;
+ if (dev->devfn == 0)
+ return 255;
+ else
+ return 11;
+ else
+ return 255;
}
extern void __init via82c505_preinit(void);
static struct hw_pci shark_pci __initdata = {
.setup = via82c505_setup,
- .swizzle = pci_std_swizzle,
+ .swizzle = pci_std_swizzle,
.map_irq = shark_map_irq,
.nr_controllers = 1,
.scan = via82c505_scan_bus,
--
1.7.1.251.gf80a2
next prev parent reply other threads:[~2010-05-23 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1274644549-24952-1-git-send-email-andrea.gelmini@gelma.net>
2010-05-23 19:55 ` [PATCH 133/199] arch/arm/boot/bootp/bootp.lds: Checkpatch cleanup Andrea Gelmini
2010-05-23 19:55 ` [PATCH 134/199] arch/arm/mach-clps711x/Makefile.boot: " Andrea Gelmini
2010-05-23 19:55 ` [PATCH 135/199] arch/arm/mach-footbridge/ebsa285-pci.c: " Andrea Gelmini
2010-05-23 19:55 ` [PATCH 136/199] arch/arm/mach-h720x/common.h: " Andrea Gelmini
2010-05-23 19:55 ` [PATCH 137/199] arch/arm/mach-sa1100/leds.c: " Andrea Gelmini
2010-05-23 19:55 ` Andrea Gelmini [this message]
2010-05-23 19:55 ` [PATCH 139/199] arch/arm/nwfpe/ChangeLog: " Andrea Gelmini
2010-05-23 19:55 ` [PATCH 140/199] arch/arm/nwfpe/fpsr.h: " Andrea Gelmini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274644549-24952-11-git-send-email-andrea.gelmini@gelma.net \
--to=andrea.gelmini@gelma.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).