linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: chasedouglas@gmail.com (Chase Douglas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 0/3] ep93xx i2s audio
Date: Wed, 26 May 2010 08:59:40 -0400	[thread overview]
Message-ID: <1274878780.9346.41.camel@cndougla-ubuntu> (raw)
In-Reply-To: <1274850588-30460-1-git-send-email-ryan@bluewatersys.com>

On Wed, 2010-05-26 at 17:09 +1200, Ryan Mallon wrote:
> The following patch series adds support for i2s audio on the ep93xx,
> with the Snapper CL15 used as an example implementation. 
> 
> I have created psuedo clocks for sclk and lrclk as suggested by
> Hartley/Mark. This moves the sdiv/lrdiv calculation into
> ep93xx_i2s_hw_parms. The ep93xx documentation implies that lrclk is
> gated for unused bits (ie if lrdiv > word length). If this is true for
> all ep93xx i2s setups then the lrclk/sclk's could be replaced by a
> single audio rate clock.
> 
> I have fixed the enabling/disabling of the i2s peripheral, which
> corrects the problem I was having with playback sometimes resulting in
> noise.

Cool!

As I looked through the patches briefly, I noticed that the first patch
depends on the second. I think they should be swapped in order so that
it is compilable after each commit. This is important when using tools
like git bisect.

-- Chase

      parent reply	other threads:[~2010-05-26 12:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26  5:09 [RFC PATCH v2 0/3] ep93xx i2s audio Ryan Mallon
2010-05-26  5:09 ` [RFC PATCH v2 1/3] ep93xx i2s audio driver Ryan Mallon
2010-05-26 11:07   ` [alsa-devel] " Liam Girdwood
2010-05-26 11:16   ` Peter Ujfalusi
2010-05-26 12:54   ` Chase Douglas
2010-05-26 13:08     ` Lothar Waßmann
2010-05-27  2:13   ` Mark Brown
2010-05-26  5:09 ` [RFC PATCH v2 2/3] ep93xx i2s core support Ryan Mallon
2010-05-26  5:09 ` [RFC PATCH v2 3/3] ep93xx i2s audio snapper cl15 support Ryan Mallon
2010-05-26 12:59 ` Chase Douglas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274878780.9346.41.camel@cndougla-ubuntu \
    --to=chasedouglas@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).