linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU
Date: Thu, 27 May 2010 16:00:48 +0100	[thread overview]
Message-ID: <1274972448-10721-1-git-send-email-will.deacon@arm.com> (raw)

CPU performance event counters on v7 cores will only operate
if either the NIDEN or DBGEN signals are driven high.

For the OMAP3 platform, these signals are driven low by default [i.e.
when a JTAG debugger is not connected] but DBGEN can be asserted in
software by selecting the OMAP3_EMU Kconfig option, which enables the
virtual clock for hardware debugging peripherals.

This patch makes CPU_HAS_PMU depend on OMAP3_EMU for OMAP3 platforms.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Jean Pihet <jpihet@mvista.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---

Since I don't have an OMAP3 board to test this on I would appreciate
it if somebody with some hardware could (a) confirm that this problem
exists and (b) validate that this patch solves the issue. Thanks!

 arch/arm/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 1f254bd..98922f7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -955,7 +955,8 @@ config XSCALE_PMU
 	default y
 
 config CPU_HAS_PMU
-	depends on CPU_V6 || CPU_V7 || XSCALE_PMU
+	depends on (CPU_V6 || CPU_V7 || XSCALE_PMU) && \
+		   (!ARCH_OMAP3 || OMAP3_EMU)
 	default y
 	bool
 
-- 
1.6.3.3

             reply	other threads:[~2010-05-27 15:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 15:00 Will Deacon [this message]
2010-06-16  8:29 ` [PATCH] OMAP3: pmu: make CPU_HAS_PMU dependent on OMAP3_EMU Jean Pihet
2010-06-16 12:33   ` Will Deacon
2010-06-21 14:35   ` Will Deacon
2010-07-01 13:07     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274972448-10721-1-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).