From: weber@corscience.de (Thomas Weber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 09/11] OMAP2: Devkit8000: Using gpio_is_valid macro
Date: Wed, 2 Jun 2010 13:37:49 +0200 [thread overview]
Message-ID: <1275478671-24563-10-git-send-email-weber@corscience.de> (raw)
In-Reply-To: <1275478671-24563-1-git-send-email-weber@corscience.de>
Using the macro gpio_is_valid for check of valid gpio pins.
Signed-off-by: Thomas Weber <weber@corscience.de>
---
arch/arm/mach-omap2/board-devkit8000.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c
index 3da88c8..dbd16de 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -134,27 +134,27 @@ static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev)
twl_i2c_write_u8(TWL4030_MODULE_GPIO, 0x80, REG_GPIODATADIR1);
twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0);
- if (dssdev->reset_gpio != -EINVAL)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 1);
return 0;
}
static void devkit8000_panel_disable_lcd(struct omap_dss_device *dssdev)
{
- if (dssdev->reset_gpio != -EINVAL)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 0);
}
static int devkit8000_panel_enable_dvi(struct omap_dss_device *dssdev)
{
- if (dssdev->reset_gpio != -EINVAL)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 1);
return 0;
}
static void devkit8000_panel_disable_dvi(struct omap_dss_device *dssdev)
{
- if (dssdev->reset_gpio != -EINVAL)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 0);
}
--
1.7.1
next prev parent reply other threads:[~2010-06-02 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 11:37 [PATCHv2 00/11] Multiple fixes for Devkit8000 Thomas Weber
2010-06-02 11:37 ` [PATCHv2 01/11] OMAP2: Devkit8000: Cleanup for power supplies Thomas Weber
2010-06-02 11:37 ` [PATCHv2 02/11] OMAP2: Devkit8000: change panel to generic panel Thomas Weber
2010-06-02 11:37 ` [PATCHv2 03/11] OMAP2: Devkit8000: Enable DVI-D output Thomas Weber
2010-06-02 11:37 ` [PATCHv2 04/11] OMAP2: Devkit8000: Setup LCD reset Thomas Weber
2010-07-05 12:57 ` Tony Lindgren
2010-06-02 11:37 ` [PATCHv2 05/11] OMAP2: Devkit8000: Remove unneeded VDVI supply Thomas Weber
2010-06-02 11:37 ` [PATCHv2 06/11] OMAP2: Devkit8000: Remove non existing vsim supply Thomas Weber
2010-06-02 11:37 ` [PATCHv2 07/11] OMAP2: Devkit8000: Remove en-/disable for tv panel Thomas Weber
2010-06-02 11:37 ` [PATCHv2 08/11] OMAP2: Devkit8000: Using the REGULATOR_SUPPLY macro Thomas Weber
2010-06-02 11:37 ` Thomas Weber [this message]
2010-06-02 11:37 ` [PATCHv2 10/11] OMAP2: Devkit8000: Remove unused omap_board_config Thomas Weber
2010-06-02 11:37 ` [PATCHv2 11/11] OMAP2: Devkit8000: Fix regulator for power supply Thomas Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275478671-24563-10-git-send-email-weber@corscience.de \
--to=weber@corscience.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).