Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jeremy.kerr@canonical.com (Jeremy Kerr)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC,PATCH 0/2] Common struct clk implementation, v4
Date: Fri, 04 Jun 2010 15:30:08 +0800	[thread overview]
Message-ID: <1275636608.606606.450179637764.0.gpush@pororo> (raw)

Hi all,

These patches are an attempt to allow platforms to share clock code. At
present, the definitions of 'struct clk' are local to platform code,
which makes allocating and initialising cross-platform clock sources
difficult, and makes it impossible to compile a single image containing
support for two ARM platforms with different struct clks.

The two patches are for the architecture-independent kernel code,
introducing the common clk infrastructure. The changelog for the first
patch includes details about the new clock definitions.

As requested by rmk, I've put together a small series of patches
illustrating the usage of the common struct clock on the ARM imx51
platform. These are available in my git tree:

 git://kernel.ubuntu.com/jk/dt/linux-2.6

in the clk-common-mx51 branch (clk-common..clk-common-mx51).

The approach I've taken with the imx51 port is to temporarly duplicate
the platform-common clock code (ie, for all mxc-based boards) to enable
usage of the common struct clk on one machine (imx51), while leaving the
others as-is. For a proper platform-wide usage of the common struct clk,
we'd be better off doing the whole platform at once. However, mx51 is
the only mxc-based HW I have, hence the duplicated example port.

In the example port, the first change simply converts the mxc's struct
clk to a struct clk_mxc, using the new API.  The subsequent patches move
certain clocks to more specific data structures (eg clk_fixed and
clk_pll) where possible.

Ben Herrenschmidt is looking at using common struct clk code for powerpc
too, hence the kernel-wide approach.

Comments most welcome.

Cheers,


Jeremy

--
v4:
 * use mutex for enable/disable locking
 * DEFINE_CLK -> INIT_CLK, and pass the clk name for mutex init
 * struct clk_operations -> struct clk_ops

v3:
 * do clock usage refcounting in common code
 * provide sample port

v2:
 * no longer ARM-specific
 * use clk_operations

---
Jeremy Kerr (2):
      Add a common struct clk
      clk: Generic support for fixed-rate clocks

             reply	other threads:[~2010-06-04  7:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  7:30 Jeremy Kerr [this message]
2010-06-04  7:30 ` [RFC,PATCH 2/2] clk: Generic support for fixed-rate clocks Jeremy Kerr
2010-06-04  7:30 ` [RFC,PATCH 1/2] Add a common struct clk Jeremy Kerr
2010-06-11  4:20   ` Ben Dooks
2010-06-11  6:50     ` Benjamin Herrenschmidt
2010-06-11  7:57     ` Jeremy Kerr
2010-06-11  8:14       ` Lothar Waßmann
2010-06-11  9:18         ` Jeremy Kerr
2010-06-11  9:23           ` Lothar Waßmann
2010-06-11  9:58             ` Uwe Kleine-König
2010-06-11 10:08               ` Lothar Waßmann
2010-06-11 10:50                 ` Jeremy Kerr
2010-06-12  5:14                 ` Benjamin Herrenschmidt
2010-06-14  6:39                   ` Lothar Waßmann
2010-06-14  6:40                     ` Uwe Kleine-König
2010-06-14  6:52                       ` Lothar Waßmann
2010-06-14  9:34                         ` Uwe Kleine-König
2010-06-16 21:14                           ` Ben Dooks
2010-06-16 21:13                         ` Ben Dooks
2010-06-14  9:22                     ` Benjamin Herrenschmidt
2010-06-14  9:30                       ` Lothar Waßmann
2010-06-14  9:43                         ` Uwe Kleine-König
2010-06-16 21:16                           ` Ben Dooks
2010-06-16 23:33                             ` Benjamin Herrenschmidt
2010-06-13 22:27                 ` Ben Dooks
2010-06-11 14:11               ` Uwe Kleine-König
2010-06-12  5:12             ` Benjamin Herrenschmidt
2010-06-12  5:10         ` Benjamin Herrenschmidt
2010-06-13 22:25         ` Ben Dooks
2010-06-13 22:23       ` Ben Dooks
2010-06-14  3:10         ` Jeremy Kerr
2010-09-10  2:10         ` Jeremy Kerr
2010-06-14 10:18     ` Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275636608.606606.450179637764.0.gpush@pororo \
    --to=jeremy.kerr@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox