* [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD
@ 2010-06-04 5:52 Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2010-06-04 5:52 UTC (permalink / raw)
To: linux-arm-kernel
The LCD was turned on if the variable power was > 0, but that was incorrect. The
LCD has to be turned on in every case but POWERDOWN.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/video/backlight/lms283gf05.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index abc43a0..6a35602 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -129,7 +129,7 @@ static int lms283gf05_power_set(struct lcd_device *ld, int power)
struct spi_device *spi = st->spi;
struct lms283gf05_pdata *pdata = spi->dev.platform_data;
- if (power) {
+ if (power < FB_BLANK_POWERDOWN) {
if (pdata)
lms283gf05_reset(pdata->reset_gpio,
pdata->reset_inverted);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD
@ 2010-06-05 1:25 Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2010-06-05 1:25 UTC (permalink / raw)
To: linux-arm-kernel
The LCD was turned on if the variable power was > 0, but that was incorrect. The
LCD has to be turned on in every case but POWERDOWN.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/video/backlight/lms283gf05.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index abc43a0..5d3cf33 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -129,7 +129,7 @@ static int lms283gf05_power_set(struct lcd_device *ld, int power)
struct spi_device *spi = st->spi;
struct lms283gf05_pdata *pdata = spi->dev.platform_data;
- if (power) {
+ if (power <= FB_BLANK_NORMAL) {
if (pdata)
lms283gf05_reset(pdata->reset_gpio,
pdata->reset_inverted);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD
@ 2010-06-05 9:50 Marek Vasut
2010-06-05 9:50 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2010-06-05 9:50 UTC (permalink / raw)
To: linux-arm-kernel
The LCD was turned on if the variable power was > 0, but that was incorrect. The
LCD has to be turned on in NORMAL and UNBLANK case.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/video/backlight/lms283gf05.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/lms283gf05.c b/drivers/video/backlight/lms283gf05.c
index abc43a0..5d3cf33 100644
--- a/drivers/video/backlight/lms283gf05.c
+++ b/drivers/video/backlight/lms283gf05.c
@@ -129,7 +129,7 @@ static int lms283gf05_power_set(struct lcd_device *ld, int power)
struct spi_device *spi = st->spi;
struct lms283gf05_pdata *pdata = spi->dev.platform_data;
- if (power) {
+ if (power <= FB_BLANK_NORMAL) {
if (pdata)
lms283gf05_reset(pdata->reset_gpio,
pdata->reset_inverted);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD
2010-06-05 9:50 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
@ 2010-06-05 9:50 ` Marek Vasut
2010-11-05 10:48 ` Alberto Panizzo
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2010-06-05 9:50 UTC (permalink / raw)
To: linux-arm-kernel
The LCD was turned on if the variable power was > 0, but that was incorrect. The
LCD has to be turned on in NORMAL and UNBLANK case.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/video/backlight/l4f00242t03.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index 9093ef0..c67801e 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
const u16 slpin = 0x10;
const u16 disoff = 0x28;
- if (power) {
+ if (power <= FB_BLANK_NORMAL) {
if (priv->lcd_on)
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD
2010-06-05 9:50 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
@ 2010-11-05 10:48 ` Alberto Panizzo
2010-11-05 11:09 ` Richard Purdie
0 siblings, 1 reply; 7+ messages in thread
From: Alberto Panizzo @ 2010-11-05 10:48 UTC (permalink / raw)
To: linux-arm-kernel
On sab, 2010-06-05 at 11:50 +0200, Marek Vasut wrote:
> The LCD was turned on if the variable power was > 0, but that was incorrect. The
> LCD has to be turned on in NORMAL and UNBLANK case.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Richard,
Are you still maintaining the backlight tree?
These two patches never hit the mainline since gen, I hope this will
happen soon since they really fix bugs :)
Best Regards,
Alberto!
Oh, add also this tag if possible:
Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
> ---
> drivers/video/backlight/l4f00242t03.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index 9093ef0..c67801e 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
> const u16 slpin = 0x10;
> const u16 disoff = 0x28;
>
> - if (power) {
> + if (power <= FB_BLANK_NORMAL) {
> if (priv->lcd_on)
> return 0;
>
--
Alberto!
Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD
2010-11-05 10:48 ` Alberto Panizzo
@ 2010-11-05 11:09 ` Richard Purdie
2010-11-05 11:20 ` Alberto Panizzo
0 siblings, 1 reply; 7+ messages in thread
From: Richard Purdie @ 2010-11-05 11:09 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2010-11-05 at 11:48 +0100, Alberto Panizzo wrote:
> On sab, 2010-06-05 at 11:50 +0200, Marek Vasut wrote:
> > The LCD was turned on if the variable power was > 0, but that was incorrect. The
> > LCD has to be turned on in NORMAL and UNBLANK case.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Richard,
> Are you still maintaining the backlight tree?
> These two patches never hit the mainline since gen, I hope this will
> happen soon since they really fix bugs :)
>
> Best Regards,
> Alberto!
>
> Oh, add also this tag if possible:
>
> Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
I've talked with Andrew Morton and we've come up with a new plan to
handle the backlight patches. I acked these the other day and they
should be heading into -rc2.
Cheers,
Richard
> > ---
> > drivers/video/backlight/l4f00242t03.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> > index 9093ef0..c67801e 100644
> > --- a/drivers/video/backlight/l4f00242t03.c
> > +++ b/drivers/video/backlight/l4f00242t03.c
> > @@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device *ld, int power)
> > const u16 slpin = 0x10;
> > const u16 disoff = 0x28;
> >
> > - if (power) {
> > + if (power <= FB_BLANK_NORMAL) {
> > if (priv->lcd_on)
> > return 0;
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD
2010-11-05 11:09 ` Richard Purdie
@ 2010-11-05 11:20 ` Alberto Panizzo
0 siblings, 0 replies; 7+ messages in thread
From: Alberto Panizzo @ 2010-11-05 11:20 UTC (permalink / raw)
To: linux-arm-kernel
On ven, 2010-11-05 at 11:09 +0000, Richard Purdie wrote:
> On Fri, 2010-11-05 at 11:48 +0100, Alberto Panizzo wrote:
> > On sab, 2010-06-05 at 11:50 +0200, Marek Vasut wrote:
> > > The LCD was turned on if the variable power was > 0, but that was incorrect. The
> > > LCD has to be turned on in NORMAL and UNBLANK case.
> > >
> > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >
> > Richard,
> > Are you still maintaining the backlight tree?
> > These two patches never hit the mainline since gen, I hope this will
> > happen soon since they really fix bugs :)
> >
> > Best Regards,
> > Alberto!
> >
> > Oh, add also this tag if possible:
> >
> > Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
>
> I've talked with Andrew Morton and we've come up with a new plan to
> handle the backlight patches. I acked these the other day and they
> should be heading into -rc2.
>
> Cheers,
>
> Richard
Ok, thank you for the quick answer!
Cheers,
--
Alberto!
Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-05 11:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 9:50 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
2010-06-05 9:50 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
2010-11-05 10:48 ` Alberto Panizzo
2010-11-05 11:09 ` Richard Purdie
2010-11-05 11:20 ` Alberto Panizzo
-- strict thread matches above, loose matches on Subject: below --
2010-06-05 1:25 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
2010-06-04 5:52 Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).