From: saeed@marvell.com (Saeed Bishara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 v2] mv643xx_eth: use sw csum for big packets
Date: Wed, 9 Jun 2010 11:51:23 +0300 [thread overview]
Message-ID: <1276073483-17208-1-git-send-email-saeed@marvell.com> (raw)
In-Reply-To: <FCBE654890C0334289D0AD3AF4EF009F9FAC75A69C@IL-MB01.marvell.com>
Some controllers (KW, Dove) limits the TX IP/layer4 checksum offloading to a max size.
Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
drivers/net/mv643xx_eth.c | 7 ++++++-
include/linux/mv643xx_eth.h | 5 +++++
2 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index e345ec8..2d0e06b 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -289,6 +289,7 @@ struct mv643xx_eth_shared_private {
unsigned int t_clk;
int extended_rx_coal_limit;
int tx_bw_control;
+ int tx_csum_limit;
};
#define TX_BW_CONTROL_ABSENT 0
@@ -782,7 +783,8 @@ static int txq_submit_skb(struct tx_queue *txq, struct sk_buff *skb)
skb->protocol != htons(ETH_P_8021Q));
tag_bytes = (void *)ip_hdr(skb) - (void *)skb->data - ETH_HLEN;
- if (unlikely(tag_bytes & ~12)) {
+ if (unlikely(tag_bytes & ~12) ||
+ skb->len > mp->shared->tx_csum_limit) {
if (skb_checksum_help(skb) == 0)
goto no_csum;
kfree_skb(skb);
@@ -2666,6 +2668,9 @@ static int mv643xx_eth_shared_probe(struct platform_device *pdev)
* Detect hardware parameters.
*/
msp->t_clk = (pd != NULL && pd->t_clk != 0) ? pd->t_clk : 133000000;
+ msp->tx_csum_limit = pd->tx_csum_limit ? pd->tx_csum_limit : 9 * 1024;
+ /* add header count so we can compare against skb->len */
+ msp->tx_csum_limit += ETH_HLEN;
infer_hw_params(msp);
platform_set_drvdata(pdev, msp);
diff --git a/include/linux/mv643xx_eth.h b/include/linux/mv643xx_eth.h
index cbbbe9b..30b0c4e 100644
--- a/include/linux/mv643xx_eth.h
+++ b/include/linux/mv643xx_eth.h
@@ -19,6 +19,11 @@ struct mv643xx_eth_shared_platform_data {
struct mbus_dram_target_info *dram;
struct platform_device *shared_smi;
unsigned int t_clk;
+ /*
+ * Max packet size for Tx IP/Layer 4 checksum, when set to 0, default
+ * limit of 9KiB will be used.
+ */
+ int tx_csum_limit;
};
#define MV643XX_ETH_PHY_ADDR_DEFAULT 0
--
1.6.0.4
next prev parent reply other threads:[~2010-06-09 8:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 12:28 [PATCH 1/2] mv643xx_eth: disable csum offloading if the hw limited by max size Saeed Bishara
2010-06-06 12:28 ` [PATCH 2/2] set packet size limit for the mv643xx csum offloading Saeed Bishara
2010-06-08 17:09 ` Lennert Buytenhek
2010-07-15 20:26 ` Martin Michlmayr
2010-07-16 6:08 ` Lennert Buytenhek
2010-08-31 11:17 ` saeed bishara
2010-08-31 13:13 ` saeed bishara
2010-08-31 16:48 ` Lennert Buytenhek
2010-09-01 7:42 ` saeed bishara
2010-09-01 7:49 ` Lennert Buytenhek
2010-08-13 22:28 ` Maxime Bizon
2010-08-31 11:17 ` saeed bishara
2010-08-31 13:13 ` saeed bishara
2010-06-08 17:08 ` [PATCH 1/2] mv643xx_eth: disable csum offloading if the hw limited by max size Lennert Buytenhek
2010-06-09 8:21 ` Saeed Bishara
2010-06-09 8:51 ` Saeed Bishara [this message]
2010-06-10 6:43 ` [PATCH 1/2 v2] mv643xx_eth: use sw csum for big packets Lennert Buytenhek
2010-06-10 7:38 ` Saeed Bishara
2010-06-12 8:31 ` Lennert Buytenhek
2010-06-13 7:38 ` Saeed Bishara
2010-06-14 9:32 ` Lennert Buytenhek
2010-06-20 11:49 ` saeed bishara
2010-06-20 11:58 ` Lennert Buytenhek
2010-06-27 4:22 ` David Miller
2010-06-09 19:10 ` [PATCH 1/2] mv643xx_eth: disable csum offloading if the hw limited by max size Lennert Buytenhek
2010-06-09 19:22 ` Abhijeet Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276073483-17208-1-git-send-email-saeed@marvell.com \
--to=saeed@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).