From: viresh.kumar@st.com (Viresh KUMAR)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] GPIO PL061: Adding Clk framework support
Date: Tue, 22 Jun 2010 10:37:27 +0530 [thread overview]
Message-ID: <1277183247-4557-1-git-send-email-viresh.kumar@st.com> (raw)
From: Viresh KUMAR <viresh.kumar@st.com>
GPIO Clk is never enabled on Platforms, like: SPEAr, which are based upon clock
framework and use PL061 driver. This patch adds support for Clk enabling and
disabling as and when gpios are requested and freed.
Modifications in V4:
- Not registering gpio_request and gpio_free if clk is not found.
Modifications in V3:
- if clk_get returns -ENOENT, then work without clk enable/disable.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/gpio/pl061.c | 49 +++++++++++++++++++++++++++++++++++++++++++------
1 files changed, 43 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/pl061.c b/drivers/gpio/pl061.c
index 105701a..b826d2b 100644
--- a/drivers/gpio/pl061.c
+++ b/drivers/gpio/pl061.c
@@ -11,7 +11,10 @@
*
* Data sheet: ARM DDI 0190B, September 2000
*/
+
+#include <linux/clk.h>
#include <linux/spinlock.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/module.h>
#include <linux/list.h>
@@ -56,8 +59,26 @@ struct pl061_gpio {
void __iomem *base;
unsigned irq_base;
struct gpio_chip gc;
+ struct clk *clk;
};
+static int pl061_request(struct gpio_chip *gc, unsigned offset)
+{
+ struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
+
+ if (offset >= gc->ngpio)
+ return -EINVAL;
+
+ return clk_enable(chip->clk);
+}
+
+static void pl061_free(struct gpio_chip *gc, unsigned offset)
+{
+ struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
+
+ clk_disable(chip->clk);
+}
+
static int pl061_direction_input(struct gpio_chip *gc, unsigned offset)
{
struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
@@ -260,9 +281,18 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)
goto release_region;
}
- spin_lock_init(&chip->lock);
- spin_lock_init(&chip->irq_lock);
- INIT_LIST_HEAD(&chip->list);
+ chip->clk = clk_get(&dev->dev, NULL);
+ if (IS_ERR(chip->clk)) {
+ ret = PTR_ERR(chip->clk);
+ /* clk Not present */
+ if (ret == -ENOENT)
+ chip->clk = NULL;
+ else
+ goto iounmap;
+ } else {
+ chip->gc.request = pl061_request;
+ chip->gc.free = pl061_free;
+ }
chip->gc.direction_input = pl061_direction_input;
chip->gc.direction_output = pl061_direction_output;
@@ -277,9 +307,13 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)
chip->irq_base = pdata->irq_base;
+ spin_lock_init(&chip->lock);
+ spin_lock_init(&chip->irq_lock);
+ INIT_LIST_HEAD(&chip->list);
+
ret = gpiochip_add(&chip->gc);
if (ret)
- goto iounmap;
+ goto free_clk;
/*
* irq_chip support
@@ -292,7 +326,7 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)
irq = dev->irq[0];
if (irq < 0) {
ret = -ENODEV;
- goto iounmap;
+ goto free_clk;
}
set_irq_chained_handler(irq, pl061_irq_handler);
if (!test_and_set_bit(irq, init_irq)) { /* list initialized? */
@@ -300,7 +334,7 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)
if (chip_list == NULL) {
clear_bit(irq, init_irq);
ret = -ENOMEM;
- goto iounmap;
+ goto free_clk;
}
INIT_LIST_HEAD(chip_list);
set_irq_data(irq, chip_list);
@@ -323,6 +357,9 @@ static int __init pl061_probe(struct amba_device *dev, struct amba_id *id)
return 0;
+free_clk:
+ if (chip->clk)
+ clk_put(chip->clk);
iounmap:
iounmap(chip->base);
release_region:
--
1.6.0.2
next reply other threads:[~2010-06-22 5:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 5:07 Viresh KUMAR [this message]
2010-06-22 17:06 ` [PATCH v4] GPIO PL061: Adding Clk framework support Baruch Siach
2010-07-09 12:40 ` Russell King - ARM Linux
2010-07-09 23:55 ` Linus Walleij
2010-07-10 7:19 ` Russell King - ARM Linux
2010-07-10 7:30 ` Russell King - ARM Linux
2010-07-10 15:36 ` Linus Walleij
2010-07-13 7:44 ` Russell King - ARM Linux
2010-07-13 11:00 ` Linus Walleij
2010-07-13 18:26 ` Russell King - ARM Linux
2010-07-15 6:02 ` Viresh KUMAR
2010-07-15 8:30 ` Russell King - ARM Linux
2010-07-15 9:35 ` Viresh KUMAR
2010-07-15 9:44 ` Linus Walleij
2010-07-15 9:56 ` Russell King - ARM Linux
2010-07-15 16:09 ` Rabin Vincent
2010-07-15 16:22 ` Russell King - ARM Linux
2010-07-29 23:22 ` Kevin Wells
2010-07-30 7:09 ` Russell King - ARM Linux
2010-08-03 0:40 ` Kevin Wells
2010-08-03 13:00 ` Linus Walleij
2010-08-03 20:36 ` Kevin Wells
2010-08-03 21:23 ` Russell King - ARM Linux
2010-07-30 15:19 ` Linus Walleij
2010-07-12 4:07 ` Viresh KUMAR
2010-07-12 7:53 ` Linus Walleij
2010-07-12 8:07 ` Russell King - ARM Linux
2010-07-12 8:18 ` Viresh KUMAR
2010-07-12 8:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277183247-4557-1-git-send-email-viresh.kumar@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).