From: segooon@gmail.com (Kulikov Vasiliy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs
Date: Thu, 15 Jul 2010 22:43:15 +0400 [thread overview]
Message-ID: <1279219395-12088-1-git-send-email-segooon@gmail.com> (raw)
divider_u71 is unsigned, so this check is buggy:
if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
If divider_u71 is 0 or 1 both checks are lying.
So, it does not produce a buggy answer, but it is confusing.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/arm/mach-tegra/tegra2_clocks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-tegra/tegra2_clocks.c b/arch/arm/mach-tegra/tegra2_clocks.c
index 4261632..64df5b4 100644
--- a/arch/arm/mach-tegra/tegra2_clocks.c
+++ b/arch/arm/mach-tegra/tegra2_clocks.c
@@ -149,7 +149,7 @@ static int clk_div71_get_divider(struct clk *c, unsigned long rate)
divider_u71 = DIV_ROUND_UP(c->rate * 2, rate);
- if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
+ if (divider_u71 > 2 + 255 || divider_u71 < 2)
return -EINVAL;
return divider_u71 - 2;
--
1.7.0.4
next reply other threads:[~2010-07-15 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:43 Kulikov Vasiliy [this message]
2010-07-20 7:14 ` [PATCH 1/8] arm/mach-tegra: fix unsigned calcs Colin Cross
2010-07-20 7:53 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279219395-12088-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).