From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] imx25: fix low level debug
Date: Fri, 16 Jul 2010 15:09:06 +0200 [thread overview]
Message-ID: <1279285747-7860-2-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <1279285747-7860-1-git-send-email-eric@eukrea.com>
DEBUG_LL is actually broken on i.MX25, this patch fix it.
Signed-off-by: Eric B?nard <eric@eukrea.com>
---
arch/arm/mach-mx25/clock.c | 3 +++
arch/arm/plat-mxc/include/mach/debug-macro.S | 4 ++--
arch/arm/plat-mxc/include/mach/mx25.h | 8 +++-----
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-mx25/clock.c b/arch/arm/mach-mx25/clock.c
index 1a58cae..02f8247 100644
--- a/arch/arm/mach-mx25/clock.c
+++ b/arch/arm/mach-mx25/clock.c
@@ -292,6 +292,9 @@ int __init mx25_clocks_init(void)
__raw_writel((1 << 19), CRM_BASE + CCM_CGCR0);
__raw_writel((0xf << 16) | (3 << 26), CRM_BASE + CCM_CGCR1);
__raw_writel((1 << 5), CRM_BASE + CCM_CGCR2);
+#if defined(CONFIG_DEBUG_LL) && !defined(CONFIG_DEBUG_ICEDCC)
+ clk_enable(&uart1_clk);
+#endif
/* Clock source for lcdc and csi is upll */
__raw_writel(__raw_readl(CRM_BASE+0x64) | (1 << 7) | (1 << 0),
diff --git a/arch/arm/plat-mxc/include/mach/debug-macro.S b/arch/arm/plat-mxc/include/mach/debug-macro.S
index 0b6e11e..2560640 100644
--- a/arch/arm/plat-mxc/include/mach/debug-macro.S
+++ b/arch/arm/plat-mxc/include/mach/debug-macro.S
@@ -23,8 +23,8 @@
#error "CONFIG_DEBUG_LL is incompatible with multiple archs"
#endif
#include <mach/mx25.h>
-#define UART_PADDR UART1_BASE_ADDR
-#define UART_VADDR MX25_AIPS1_IO_ADDRESS(UART1_BASE_ADDR)
+#define UART_PADDR MX25_UART1_BASE_ADDR
+#define UART_VADDR MX25_AIPS1_IO_ADDRESS(MX25_UART1_BASE_ADDR)
#endif
#ifdef CONFIG_ARCH_MX2
diff --git a/arch/arm/plat-mxc/include/mach/mx25.h b/arch/arm/plat-mxc/include/mach/mx25.h
index 2f2aad1..11b044f 100644
--- a/arch/arm/plat-mxc/include/mach/mx25.h
+++ b/arch/arm/plat-mxc/include/mach/mx25.h
@@ -31,6 +31,9 @@
IMX_IO_ADDRESS(x, MX25_AIPS2) ?: \
IMX_IO_ADDRESS(x, MX25_AVIC))
+#define MX25_AIPS1_IO_ADDRESS(x) \
+ (((x) - MX25_AIPS1_BASE_ADDR) + MX25_AIPS1_BASE_ADDR_VIRT)
+
#define MX25_UART1_BASE_ADDR 0x43f90000
#define MX25_UART2_BASE_ADDR 0x43f94000
#define MX25_AUDMUX_BASE_ADDR 0x43fb0000
@@ -70,9 +73,4 @@
#define MX25_INT_UART1 45
#define MX25_INT_FEC 57
-#if defined(IMX_NEEDS_DEPRECATED_SYMBOLS)
-#define UART1_BASE_ADDR MX25_UART1_BASE_ADDR
-#define UART2_BASE_ADDR MX25_UART2_BASE_ADDR
-#endif
-
#endif /* ifndef __MACH_MX25_H__ */
--
1.6.3.3
next prev parent reply other threads:[~2010-07-16 13:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 13:09 [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Eric Bénard
2010-07-16 13:09 ` Eric Bénard [this message]
2010-07-16 13:09 ` [PATCH 3/3] imxfb: add pwmr controlled backlight support Eric Bénard
2010-07-29 5:16 ` Uwe Kleine-König
2010-07-29 8:42 ` [PATCH] video/imxfb.c: allow usage without BACKLIGHT_CLASS_DEVICE Eric Bénard
2010-07-29 9:11 ` Uwe Kleine-König
2010-07-29 9:47 ` [PATCH v2] " Eric Bénard
2010-07-29 12:45 ` Uwe Kleine-König
2010-07-29 13:03 ` Eric Bénard
2010-07-29 13:03 ` [PATCH v3] " Eric Bénard
2010-07-29 13:23 ` Sergei Shtylyov
2010-07-29 13:33 ` Eric Bénard
2010-07-29 14:17 ` [PATCH v4] " Eric Bénard
2010-07-29 15:01 ` Uwe Kleine-König
2010-08-02 7:39 ` [PATCH] " Uwe Kleine-König
2010-07-29 13:37 ` [PATCH v3] " Lothar Waßmann
2010-07-29 8:49 ` [PATCH 3/3] imxfb: add pwmr controlled backlight support Eric Bénard
2010-07-22 15:51 ` [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279285747-7860-2-git-send-email-eric@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).