From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] [ARM] pxa: use generic gpio_get_value() instead of READ_GPIO_BIT()
Date: Mon, 19 Jul 2010 12:58:58 +0200 [thread overview]
Message-ID: <1279537144-25424-3-git-send-email-eric.y.miao@gmail.com> (raw)
In-Reply-To: <1279537144-25424-1-git-send-email-eric.y.miao@gmail.com>
READ_GPIO_BIT() is no way generic by accessing GPIO registers directly,
replace it with gpio_get_value().
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
---
arch/arm/mach-pxa/corgi_pm.c | 6 +++---
arch/arm/mach-pxa/spitz_pm.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-pxa/corgi_pm.c b/arch/arm/mach-pxa/corgi_pm.c
index a735205..41cf945 100644
--- a/arch/arm/mach-pxa/corgi_pm.c
+++ b/arch/arm/mach-pxa/corgi_pm.c
@@ -134,11 +134,11 @@ unsigned long corgipm_read_devdata(int type)
case SHARPSL_STATUS_ACIN:
return ((GPLR(CORGI_GPIO_AC_IN) & GPIO_bit(CORGI_GPIO_AC_IN)) != 0);
case SHARPSL_STATUS_LOCK:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batlock);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_batlock);
case SHARPSL_STATUS_CHRGFULL:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batfull);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_batfull);
case SHARPSL_STATUS_FATAL:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_fatal);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_fatal);
case SHARPSL_ACIN_VOLT:
return sharpsl_pm_pxa_read_max1111(MAX1111_ACIN_VOLT);
case SHARPSL_BATT_TEMP:
diff --git a/arch/arm/mach-pxa/spitz_pm.c b/arch/arm/mach-pxa/spitz_pm.c
index b36f0ae..53103d3 100644
--- a/arch/arm/mach-pxa/spitz_pm.c
+++ b/arch/arm/mach-pxa/spitz_pm.c
@@ -178,11 +178,11 @@ unsigned long spitzpm_read_devdata(int type)
case SHARPSL_STATUS_ACIN:
return (((~GPLR(SPITZ_GPIO_AC_IN)) & GPIO_bit(SPITZ_GPIO_AC_IN)) != 0);
case SHARPSL_STATUS_LOCK:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batlock);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_batlock);
case SHARPSL_STATUS_CHRGFULL:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_batfull);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_batfull);
case SHARPSL_STATUS_FATAL:
- return READ_GPIO_BIT(sharpsl_pm.machinfo->gpio_fatal);
+ return gpio_get_value(sharpsl_pm.machinfo->gpio_fatal);
case SHARPSL_ACIN_VOLT:
return sharpsl_pm_pxa_read_max1111(MAX1111_ACIN_VOLT);
case SHARPSL_BATT_TEMP:
--
1.7.1
next prev parent reply other threads:[~2010-07-19 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 10:58 [PATCH 1/9] [ARM] pxa/spitz: remove unused declarations Eric Miao
2010-07-19 10:58 ` [PATCH 2/9] [ARM] pxa/corgi: remove unused declarations of corgiscoop_device Eric Miao
2010-07-19 10:58 ` Eric Miao [this message]
2010-07-19 10:58 ` [PATCH 4/9] [ARM] pxa: removed mostly unused and confusing two sharpsl.h Eric Miao
2010-07-19 14:54 ` Marek Vasut
2010-07-19 10:59 ` [PATCH 5/9] [ARM] mmp: remove never supported .boot_params for MMP Eric Miao
2010-07-19 10:59 ` [PATCH 6/9] [ARM] mmp: rename pxa_map_io() to mmp_map_io() Eric Miao
2010-07-19 10:59 ` [PATCH 7/9] [ARM] mmp: move mmp2 specific timer code to mmp2.c Eric Miao
2010-07-19 10:59 ` [PATCH 8/9] [ARM] mmp: avoid devices.h being included multiple times Eric Miao
2010-07-19 10:59 ` [PATCH 9/9] [ARM] mmp: move declarations into SoC specific header file from common.h Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279537144-25424-3-git-send-email-eric.y.miao@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).