From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] regulator: MAX8998: set_voltage bugfix. ramp_up delay and min/max voltage
Date: Thu, 22 Jul 2010 13:02:10 +0100 [thread overview]
Message-ID: <1279800130.3083.44.camel@odin> (raw)
In-Reply-To: <1279606027-18345-1-git-send-email-m.szyprowski@samsung.com>
On Tue, 2010-07-20 at 08:07 +0200, Marek Szyprowski wrote:
> From: MyungJoo Ham <myungjoo.ham@samsung.com>
>
> Two issues are addressed for max8998_set_voltage function.
>
> 1. Min/Max Voltage.
>
> max8998_set_voltage had been using the voltage value of
>
> min ( voltage[i] >= max_vol , i )
>
> This is corrected to use:
>
> min ( voltage[i] >= min_vol , i )
>
> 2. Ramp Up Delay.
>
> max8998_set_voltage should provide delay for BUCK1/2
> if ENRAMP is on. It reads RAMP value from ONOFF4 register to determine
> RAMP delay length. However, when max8998_set_voltage's new voltage is
> lower than the previous, we don't care because it does not deteriorate
> the stability.
>
> Changes since v1:
> - rebased onto latest regulator-for-next tree
Applied. Btw, please run checkpatch and/or cleanpatch before submitting
next time as this patch contained some trailing white space.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-07-22 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 8:09 [PATCH] regulator: MAX8998: set_voltage bugfix. ramp_up delay and min/max voltage MyungJoo Ham
2010-07-16 8:20 ` Mark Brown
2010-07-16 8:50 ` Marek Szyprowski
2010-07-17 18:24 ` Liam Girdwood
2010-07-20 6:07 ` [PATCH v2] " Marek Szyprowski
2010-07-20 8:54 ` Mark Brown
2010-07-22 12:02 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279800130.3083.44.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).