From mboxrd@z Thu Jan 1 00:00:00 1970 From: lrg@slimlogic.co.uk (Liam Girdwood) Date: Thu, 22 Jul 2010 13:02:10 +0100 Subject: [PATCH v2] regulator: MAX8998: set_voltage bugfix. ramp_up delay and min/max voltage In-Reply-To: <1279606027-18345-1-git-send-email-m.szyprowski@samsung.com> References: <1279391048.3070.11.camel@odin> <1279606027-18345-1-git-send-email-m.szyprowski@samsung.com> Message-ID: <1279800130.3083.44.camel@odin> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2010-07-20 at 08:07 +0200, Marek Szyprowski wrote: > From: MyungJoo Ham > > Two issues are addressed for max8998_set_voltage function. > > 1. Min/Max Voltage. > > max8998_set_voltage had been using the voltage value of > > min ( voltage[i] >= max_vol , i ) > > This is corrected to use: > > min ( voltage[i] >= min_vol , i ) > > 2. Ramp Up Delay. > > max8998_set_voltage should provide delay for BUCK1/2 > if ENRAMP is on. It reads RAMP value from ONOFF4 register to determine > RAMP delay length. However, when max8998_set_voltage's new voltage is > lower than the previous, we don't care because it does not deteriorate > the stability. > > Changes since v1: > - rebased onto latest regulator-for-next tree Applied. Btw, please run checkpatch and/or cleanpatch before submitting next time as this patch contained some trailing white space. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk