* [PATCH 01/10] arm: leds: check return value of request_region()
@ 2010-07-28 16:38 Kulikov Vasiliy
2010-07-28 18:01 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-28 16:38 UTC (permalink / raw)
To: linux-arm-kernel
request_region() may fail, if so return -ENOMEM.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/arm/mach-shark/leds.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-shark/leds.c b/arch/arm/mach-shark/leds.c
index c9e32de..cb1a8f2 100644
--- a/arch/arm/mach-shark/leds.c
+++ b/arch/arm/mach-shark/leds.c
@@ -155,7 +155,8 @@ static int __init leds_init(void)
leds_event = sequoia_leds_event;
/* Make LEDs independent of power-state */
- request_region(0x24,4,"sequoia");
+ if (request_region(0x24, 4, "sequoia") == NULL)
+ return -ENOMEM;
temp = sequoia_read(0x09);
temp |= 1<<10;
sequoia_write(temp,0x09);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 01/10] arm: leds: check return value of request_region()
2010-07-28 16:38 [PATCH 01/10] arm: leds: check return value of request_region() Kulikov Vasiliy
@ 2010-07-28 18:01 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-07-28 18:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 28, 2010 at 08:38:47PM +0400, Kulikov Vasiliy wrote:
> request_region() may fail, if so return -ENOMEM.
I think -EBUSY is more normal, although some people return -ENODEV or
-EIO. But I would think -EBUSY is the right one.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-28 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28 16:38 [PATCH 01/10] arm: leds: check return value of request_region() Kulikov Vasiliy
2010-07-28 18:01 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).