From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/12] mxc_nand: Do not do byte accesses to the NFC buffer.
Date: Mon, 9 Aug 2010 15:20:53 +0200 [thread overview]
Message-ID: <1281360053-8386-10-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1281360053-8386-1-git-send-email-s.hauer@pengutronix.de>
From: John Ogness <john.ogness@linutronix.de>
This patch avoids byte access to the NFC buffer. Byte access to the
NFC is not allowed.
The patch is against linux-next 20100618.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/mxc_nand.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index d88f0fa..a85b60a 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -402,16 +402,16 @@ static void send_read_id_v1_v2(struct mxc_nand_host *host)
/* Wait for operation to complete */
wait_op_done(host, true);
+ memcpy(host->data_buf, host->main_area0, 16);
+
if (this->options & NAND_BUSWIDTH_16) {
- void __iomem *main_buf = host->main_area0;
/* compress the ID info */
- writeb(readb(main_buf + 2), main_buf + 1);
- writeb(readb(main_buf + 4), main_buf + 2);
- writeb(readb(main_buf + 6), main_buf + 3);
- writeb(readb(main_buf + 8), main_buf + 4);
- writeb(readb(main_buf + 10), main_buf + 5);
+ host->data_buf[1] = host->data_buf[2];
+ host->data_buf[2] = host->data_buf[4];
+ host->data_buf[3] = host->data_buf[6];
+ host->data_buf[4] = host->data_buf[8];
+ host->data_buf[5] = host->data_buf[10];
}
- memcpy(host->data_buf, host->main_area0, 16);
}
static uint16_t get_dev_status_v3(struct mxc_nand_host *host)
--
1.7.1
next prev parent reply other threads:[~2010-08-09 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 13:20 [v2] Add i.MX51 support to mxc_nand Sascha Hauer
2010-08-09 13:20 ` [PATCH 01/12] mxc_nand: remove 0xe00 offset from registers Sascha Hauer
2010-08-09 13:20 ` [PATCH 02/12] mxc_nand: rework get_dev_status Sascha Hauer
2010-08-09 13:20 ` [PATCH 03/12] mxc_nand: make some internally used functions overwriteable Sascha Hauer
2010-08-09 13:20 ` [PATCH 04/12] mxc_nand: factor out a check_int function Sascha Hauer
2010-08-09 13:20 ` [PATCH 05/12] mxc_nand: add V1_V2 namespace to registers Sascha Hauer
2010-08-09 13:20 ` [PATCH 06/12] mxc_nand: support 8bit ecc Sascha Hauer
2010-08-09 13:20 ` [PATCH 07/12] mxc_nand: fix correct_data function Sascha Hauer
2010-08-09 13:20 ` [PATCH 08/12] mxc_nand: Add v3 (i.MX51) Support Sascha Hauer
2010-08-09 13:20 ` Sascha Hauer [this message]
2010-08-10 11:31 ` [v2] Add i.MX51 support to mxc_nand John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281360053-8386-10-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).