From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mxc_nand: factor out a check_int function
Date: Mon, 9 Aug 2010 15:20:48 +0200 [thread overview]
Message-ID: <1281360053-8386-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1281360053-8386-1-git-send-email-s.hauer@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/mxc_nand.c | 32 +++++++++++++++++++-------------
1 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 2d2e2e7..70f64dc 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -122,6 +122,7 @@ struct mxc_nand_host {
void (*send_page)(struct mtd_info *, unsigned int);
void (*send_read_id)(struct mxc_nand_host *);
uint16_t (*get_dev_status)(struct mxc_nand_host *);
+ int (*check_int)(struct mxc_nand_host *);
};
/* OOB placement block for use with hardware ecc generation */
@@ -181,34 +182,38 @@ static irqreturn_t mxc_nfc_irq(int irq, void *dev_id)
return IRQ_HANDLED;
}
+static int check_int_v1_v2(struct mxc_nand_host *host)
+{
+ uint32_t tmp;
+
+ tmp = readw(host->regs + NFC_CONFIG2);
+ if (!(tmp & NFC_INT))
+ return 0;
+
+ writew(tmp & ~NFC_INT, NFC_CONFIG2);
+
+ return 1;
+}
+
/* This function polls the NANDFC to wait for the basic operation to
* complete by checking the INT bit of config2 register.
*/
static void wait_op_done(struct mxc_nand_host *host, int useirq)
{
- uint16_t tmp;
int max_retries = 8000;
if (useirq) {
- if ((readw(host->regs + NFC_CONFIG2) & NFC_INT) == 0) {
+ if (!host->check_int(host)) {
enable_irq(host->irq);
- wait_event(host->irq_waitq,
- readw(host->regs + NFC_CONFIG2) & NFC_INT);
-
- tmp = readw(host->regs + NFC_CONFIG2);
- tmp &= ~NFC_INT;
- writew(tmp, host->regs + NFC_CONFIG2);
+ wait_event(host->irq_waitq, host->check_int(host));
}
} else {
while (max_retries-- > 0) {
- if (readw(host->regs + NFC_CONFIG2) & NFC_INT) {
- tmp = readw(host->regs + NFC_CONFIG2);
- tmp &= ~NFC_INT;
- writew(tmp, host->regs + NFC_CONFIG2);
+ if (host->check_int(host))
break;
- }
+
udelay(1);
}
if (max_retries < 0)
@@ -774,6 +779,7 @@ static int __init mxcnd_probe(struct platform_device *pdev)
host->send_page = send_page_v1_v2;
host->send_read_id = send_read_id_v1_v2;
host->get_dev_status = get_dev_status_v1_v2;
+ host->check_int = check_int_v1_v2;
}
if (nfc_is_v21()) {
--
1.7.1
next prev parent reply other threads:[~2010-08-09 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 13:20 [v2] Add i.MX51 support to mxc_nand Sascha Hauer
2010-08-09 13:20 ` [PATCH 01/12] mxc_nand: remove 0xe00 offset from registers Sascha Hauer
2010-08-09 13:20 ` [PATCH 02/12] mxc_nand: rework get_dev_status Sascha Hauer
2010-08-09 13:20 ` [PATCH 03/12] mxc_nand: make some internally used functions overwriteable Sascha Hauer
2010-08-09 13:20 ` Sascha Hauer [this message]
2010-08-09 13:20 ` [PATCH 05/12] mxc_nand: add V1_V2 namespace to registers Sascha Hauer
2010-08-09 13:20 ` [PATCH 06/12] mxc_nand: support 8bit ecc Sascha Hauer
2010-08-09 13:20 ` [PATCH 07/12] mxc_nand: fix correct_data function Sascha Hauer
2010-08-09 13:20 ` [PATCH 08/12] mxc_nand: Add v3 (i.MX51) Support Sascha Hauer
2010-08-09 13:20 ` [PATCH 09/12] mxc_nand: Do not do byte accesses to the NFC buffer Sascha Hauer
2010-08-10 11:31 ` [v2] Add i.MX51 support to mxc_nand John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281360053-8386-5-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).