From: ohad@wizery.com (Ohad Ben-Cohen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 1/6] mmc: sdio: fully reconfigure oldcard on resume
Date: Wed, 11 Aug 2010 16:19:25 +0300 [thread overview]
Message-ID: <1281532770-27545-2-git-send-email-ohad@wizery.com> (raw)
In-Reply-To: <1281532770-27545-1-git-send-email-ohad@wizery.com>
On resume, let mmc_sdio_init_card go all the way, instead
of skipping the reconfiguration of the card's speed and width.
This is needed to ensure cards wake up with their clock
reconfigured (otherwise it's kept low).
This patch also removes the explicit bus width reconfiguration
on resume, since now this is part of mmc_sdio_init_card.
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
drivers/mmc/core/sdio.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index b9dee28..645f173 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -344,7 +344,6 @@ static int mmc_sdio_init_card(struct mmc_host *host, u32 ocr,
goto err;
}
card = oldcard;
- return 0;
}
/*
@@ -487,9 +486,6 @@ static int mmc_sdio_resume(struct mmc_host *host)
mmc_claim_host(host);
err = mmc_sdio_init_card(host, host->ocr, host->card,
(host->pm_flags & MMC_PM_KEEP_POWER));
- if (!err)
- /* We may have switched to 1-bit mode during suspend. */
- err = sdio_enable_wide(host->card);
if (!err && host->sdio_irqs)
mmc_signal_sdio_irq(host);
mmc_release_host(host);
--
1.7.0.4
next prev parent reply other threads:[~2010-08-11 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 13:19 [RFC 0/6] adding SDIO Runtime PM support Ohad Ben-Cohen
2010-08-11 13:19 ` Ohad Ben-Cohen [this message]
2010-08-11 13:19 ` [RFC/PATCH 2/6] sdio: add power_restore support Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 3/6] mmc: add general runtime PM support Ohad Ben-Cohen
2010-08-26 9:42 ` Gao, Yunpeng
2010-09-01 20:08 ` Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 4/6] sdio: " Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 5/6] sdio: enable Runtime PM for SDIO cards Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 6/6] wireless: wl1271_sdio: enable Runtime PM Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281532770-27545-2-git-send-email-ohad@wizery.com \
--to=ohad@wizery.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).