From: wellsk40@gmail.com (wellsk40 at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: RTC: LPC32xx: Introduce RTC driver for the LPC32xx (v4)
Date: Tue, 17 Aug 2010 13:00:33 -0700 [thread overview]
Message-ID: <1282075234-18644-1-git-send-email-wellsk40@gmail.com> (raw)
This patch set adds support for the LPC32xx built-in RTC. This is
a persistent RTC with alarm on it's own power domain and a
dedicated oscillator. UIE emulation is used for *_UIE_* ioctls.
The patch can be pulled from:
git://git.lpclinux.com/linux-2.6-lpc rtc-lpc32xx_v4
v4 includes updates from the initial review of the RTC driver
and updates from v2 and v3
Changes since v3:
Some RTC macros renamed (and shrunk)
Fixed RTC key load logic that would cause RTC clock
to clear to 0 on poweroff or reset if key
wasn't set elsewhere
Fixed else case for RTC key check (key present) to
clear MATCH0 instead on ONSW_MATCH0
Changes since v2:
RTC register macros now prefixed with LPC32XX_
Changed alarm_enable type to unsigned char to match
the type in the struct rtc_wkalrm (enable)
Set pending flag to correct state in read-alarm
function
Change the alarm read failure message to a warning
Regardless of the state of the alarm enable flag
passed into set_alarm, the alarm fire value
is updated. Previously, this was only updated
when the alarm enable flag was set
Added braces for else clauses with a single statement
if the previous if clause had them
Cleared platform data pointer in rtc structure on
error and remove
Changes since v1:
Fixed spaces/tabbing in lpc32xx entry in Kconfig/Makefile
Remove improper enable for rtc->alarm_enabled
Removed typecast on rtc structure in irq handler
Switch to resource managed (devm_) variants of kzalloc
and other functions in probe. Updated remove
based on these changes.
Disabled alarm on probe instead of keeping current register
settings. No changes for suspend.
Allowed driver to continue operation without wakeup or
alarm irq if the rtc irq request failed.
Relocated module_init and _exit macros to just after it's
associated function
Passed a NULL pointer to .driver.pm in platform driver
structure instead of a list of NULL functions.
Added MODULE_ALIAS
next reply other threads:[~2010-08-17 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 20:00 wellsk40 at gmail.com [this message]
2010-08-17 20:00 ` [PATCH] rtc: rtc-lpc32xx: Introduce RTC driver for the LPC32XX SoC (v4) wellsk40 at gmail.com
2010-08-19 9:35 ` [rtc-linux] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282075234-18644-1-git-send-email-wellsk40@gmail.com \
--to=wellsk40@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).