From: wellsk40@gmail.com (wellsk40 at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: LPC32xx: Fix gpiolib bit mask macro
Date: Wed, 18 Aug 2010 16:40:56 -0700 [thread overview]
Message-ID: <1282174859-8780-4-git-send-email-wellsk40@gmail.com> (raw)
In-Reply-To: <1282174859-8780-1-git-send-email-wellsk40@gmail.com>
From: Kevin Wells <wellsk40@gmail.com>
The GPIO bank 3 input mask macro was missing a critical mask that
would cause it to return invalid pin states
Signed-off-by: Kevin Wells <wellsk40@gmail.com>
---
arch/arm/mach-lpc32xx/gpiolib.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-lpc32xx/gpiolib.c b/arch/arm/mach-lpc32xx/gpiolib.c
index 69061ea..16577c5 100644
--- a/arch/arm/mach-lpc32xx/gpiolib.c
+++ b/arch/arm/mach-lpc32xx/gpiolib.c
@@ -59,7 +59,8 @@
#define GPO3_PIN_TO_BIT(x) (1 << (x))
#define GPIO012_PIN_IN_SEL(x, y) (((x) >> (y)) & 1)
#define GPIO3_PIN_IN_SHIFT(x) ((x) == 5 ? 24 : 10 + (x))
-#define GPIO3_PIN_IN_SEL(x, y) ((x) >> GPIO3_PIN_IN_SHIFT(y))
+#define GPIO3_PIN_IN_SEL(x, y) (((x) >> \
+ GPIO3_PIN_IN_SHIFT(y)) & 1)
#define GPIO3_PIN5_IN_SEL(x) (((x) >> 24) & 1)
#define GPI3_PIN_IN_SEL(x, y) (((x) >> (y)) & 1)
--
1.7.1.1
next prev parent reply other threads:[~2010-08-18 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 23:40 ARM: LPC32XX: Various minor fixes and updates wellsk40 at gmail.com
2010-08-18 23:40 ` [PATCH 1/6] ARM: LPC32XX: Fix several clock device ID strings wellsk40 at gmail.com
2010-08-18 23:40 ` [PATCH 2/6] ARM: LPC32XX: Fix naming convention issues with some defines wellsk40 at gmail.com
2010-08-18 23:40 ` wellsk40 at gmail.com [this message]
2010-08-18 23:40 ` [PATCH 4/6] ARM: LPC32xx: Remove MMC peripheral clock enable/disable code wellsk40 at gmail.com
2010-08-18 23:40 ` [PATCH 5/6] ARM: LPC32XX: Remove clock enable code for AMBA driver wellsk40 at gmail.com
2010-08-18 23:40 ` [PATCH 6/6] ARM: LPC32XX: Add board.h for platform_data structures wellsk40 at gmail.com
2010-08-19 8:58 ` ARM: LPC32XX: Various minor fixes and updates Wolfram Sang
2010-08-19 18:30 ` Kevin Wells
2010-08-20 22:16 ` Kevin Wells
2010-09-01 7:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282174859-8780-4-git-send-email-wellsk40@gmail.com \
--to=wellsk40@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).