From: jeremy.kerr@canonical.com (Jeremy Kerr)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm: return both physical and virtual addresses from addruart
Date: Mon, 23 Aug 2010 22:36:45 +0800 [thread overview]
Message-ID: <1282574205.2845.47.camel@pororo> (raw)
In-Reply-To: <20100823100519.GA8018@pengutronix.de>
Hi Uwe,
> > + .macro addruart_current, rx, tmp1, tmp2
> > + addruart \tmp1, \tmp2
> > + mrc p15, 0, \rx, c1, c0
> > + tst \rx, #1
> > + moveq \rx, \tmp1
> > + movne \rx, \tmp2
> > + .endm
> Don't you need to depend on MMU somehow to do this in generic code?
>
Yeah, it would make sense to have a separate paths for CONFIG_MMU/!
CONFIG_MMU (the latter just using \tmp1).
Although, What will the mrc instruction do if there is no MMU? if it
doesn't cause an exception, we can assume that the platform's addruart
macro will return the same address in both registers and the existing
code will just work.
Cheers,
Jeremy
next prev parent reply other threads:[~2010-08-23 14:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 8:50 [PATCH 0/3] Allow late mdesc detection, v4 Jeremy Kerr
2010-08-23 8:50 ` [PATCH 1/3] arm/debug: consolidate addruart macros for CONFIG_DEBUG_ICEDCC Jeremy Kerr
2010-08-23 8:50 ` [PATCH 3/3] arm: use addruart macro to establish debug mappings Jeremy Kerr
2010-08-23 8:50 ` [PATCH 2/3] arm: return both physical and virtual addresses from addruart Jeremy Kerr
2010-08-23 10:05 ` Uwe Kleine-König
2010-08-23 14:36 ` Jeremy Kerr [this message]
2010-08-27 18:21 ` [PATCH 0/3] Allow late mdesc detection, v4 Kevin Hilman
2010-08-30 4:07 ` Jeremy Kerr
2010-08-30 16:22 ` Kevin Hilman
2010-09-01 7:39 ` Russell King - ARM Linux
2010-10-15 3:42 ` Nicolas Pitre
2010-10-18 14:19 ` Russell King - ARM Linux
2010-10-18 14:32 ` Nicolas Pitre
2010-10-19 1:34 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-09-01 1:07 [PATCH 0/3] Allow late mdesc detection, v5 Jeremy Kerr
2010-09-01 1:07 ` [PATCH 2/3] arm: return both physical and virtual addresses from addruart Jeremy Kerr
2010-10-18 22:01 ` Daniel Walker
2010-10-18 22:13 ` Russell King - ARM Linux
2010-10-18 22:44 ` Daniel Walker
2010-10-19 7:54 ` Uwe Kleine-König
2010-10-18 22:30 ` Nicolas Pitre
2010-10-18 22:52 ` Daniel Walker
2010-07-30 9:22 [PATCH 0/3] Allow late mdesc detection, v3 Jeremy Kerr
2010-07-30 9:22 ` [PATCH 2/3] arm: return both physical and virtual addresses from addruart Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282574205.2845.47.camel@pororo \
--to=jeremy.kerr@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox