* [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler
@ 2010-09-08 17:29 Scott Ellis
2010-09-09 6:17 ` Eero Nurkkala
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Scott Ellis @ 2010-09-08 17:29 UTC (permalink / raw)
To: linux-arm-kernel
Looks like a typo from commit d6d834b010.
Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
---
arch/arm/plat-omap/mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index e31496e..0c8612f 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)
/* Writing zero to RSYNC_ERR clears the IRQ */
MCBSP_WRITE(mcbsp_rx, SPCR1, MCBSP_READ_CACHE(mcbsp_rx, SPCR1));
} else {
- complete(&mcbsp_rx->tx_irq_completion);
+ complete(&mcbsp_rx->rx_irq_completion);
}
return IRQ_HANDLED;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler
2010-09-08 17:29 [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler Scott Ellis
@ 2010-09-09 6:17 ` Eero Nurkkala
2010-09-09 6:24 ` Jarkko Nikula
2010-09-10 5:30 ` Peter Ujfalusi
2 siblings, 0 replies; 4+ messages in thread
From: Eero Nurkkala @ 2010-09-09 6:17 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2010-09-08 at 19:29 +0200, ext Scott Ellis wrote:
> Looks like a typo from commit d6d834b010.
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> arch/arm/plat-omap/mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Indeed my typo.
Acked-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index e31496e..0c8612f 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)
> /* Writing zero to RSYNC_ERR clears the IRQ */
> MCBSP_WRITE(mcbsp_rx, SPCR1, MCBSP_READ_CACHE(mcbsp_rx, SPCR1));
> } else {
> - complete(&mcbsp_rx->tx_irq_completion);
> + complete(&mcbsp_rx->rx_irq_completion);
> }
>
> return IRQ_HANDLED;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler
2010-09-08 17:29 [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler Scott Ellis
2010-09-09 6:17 ` Eero Nurkkala
@ 2010-09-09 6:24 ` Jarkko Nikula
2010-09-10 5:30 ` Peter Ujfalusi
2 siblings, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2010-09-09 6:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 08 Sep 2010 13:29:01 -0400
Scott Ellis <scott@jumpnowtek.com> wrote:
> Looks like a typo from commit d6d834b010.
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> arch/arm/plat-omap/mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index e31496e..0c8612f 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)
> /* Writing zero to RSYNC_ERR clears the IRQ */
> MCBSP_WRITE(mcbsp_rx, SPCR1, MCBSP_READ_CACHE(mcbsp_rx, SPCR1));
> } else {
> - complete(&mcbsp_rx->tx_irq_completion);
> + complete(&mcbsp_rx->rx_irq_completion);
> }
>
It looks so.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler
2010-09-08 17:29 [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler Scott Ellis
2010-09-09 6:17 ` Eero Nurkkala
2010-09-09 6:24 ` Jarkko Nikula
@ 2010-09-10 5:30 ` Peter Ujfalusi
2 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2010-09-10 5:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 08 September 2010 20:29:01 ext Scott Ellis wrote:
> Looks like a typo from commit d6d834b010.
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> arch/arm/plat-omap/mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index e31496e..0c8612f 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq,
> void *dev_id) /* Writing zero to RSYNC_ERR clears the IRQ */
> MCBSP_WRITE(mcbsp_rx, SPCR1, MCBSP_READ_CACHE(mcbsp_rx, SPCR1));
> } else {
> - complete(&mcbsp_rx->tx_irq_completion);
> + complete(&mcbsp_rx->rx_irq_completion);
> }
>
> return IRQ_HANDLED;
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-10 5:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 17:29 [PATCH] OMAP: McBSP: tx_irq_completion used in rx_irq_handler Scott Ellis
2010-09-09 6:17 ` Eero Nurkkala
2010-09-09 6:24 ` Jarkko Nikula
2010-09-10 5:30 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).