linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] GIC: Dont disable INT in ack callback
Date: Thu,  9 Sep 2010 12:58:09 -0700	[thread overview]
Message-ID: <1284062289-10914-5-git-send-email-dwalker@codeaurora.org> (raw)
In-Reply-To: <1284062289-10914-1-git-send-email-dwalker@codeaurora.org>

From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>

Unless gic_ack_irq is called from __do_IRQ, interrupt should not
be disabled in the ack function.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Jeff Ohlstein <johlstei@codeaurora.org>
Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
---
 arch/arm/common/gic.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index 7dfa9a8..ada6359 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -67,25 +67,11 @@ static inline unsigned int gic_irq(unsigned int irq)
 
 /*
  * Routines to acknowledge, disable and enable interrupts
- *
- * Linux assumes that when we're done with an interrupt we need to
- * unmask it, in the same way we need to unmask an interrupt when
- * we first enable it.
- *
- * The GIC has a separate notion of "end of interrupt" to re-enable
- * an interrupt after handling, in order to support hardware
- * prioritisation.
- *
- * We can make the GIC behave in the way that Linux expects by making
- * our "acknowledge" routine disable the interrupt, then mark it as
- * complete.
  */
 static void gic_ack_irq(unsigned int irq)
 {
-	u32 mask = 1 << (irq % 32);
 
 	spin_lock(&irq_controller_lock);
-	writel(mask, gic_dist_base(irq) + GIC_DIST_ENABLE_CLEAR + (gic_irq(irq) / 32) * 4);
 	writel(gic_irq(irq), gic_cpu_base(irq) + GIC_CPU_EOI);
 	spin_unlock(&irq_controller_lock);
 }
-- 
1.7.1

      parent reply	other threads:[~2010-09-09 19:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 19:58 [GIT PULL] generic arm MSM changes for v2.6.37 Daniel Walker
2010-09-09 19:58 ` [PATCH 1/4] arm: Kconfig option for ARCH_MSM_SCORPIONMP Daniel Walker
2010-09-10 10:14   ` Sergei Shtylyov
2010-09-10 14:51     ` Uwe Kleine-König
2010-09-10 15:04       ` Daniel Walker
2010-09-11 11:02       ` Sergei Shtylyov
2010-09-10 15:15     ` Lorenzo Pieralisi
2010-09-10 20:36   ` Russell King - ARM Linux
2010-09-10 21:01     ` Daniel Walker
2010-09-09 19:58 ` [PATCH 2/4] arm: dis-allow hotplug on MSM Daniel Walker
2010-09-30  7:19   ` Pavel Machek
2010-09-30 16:45     ` Daniel Walker
2010-09-30 18:09       ` Daniel Walker
2010-09-30 19:52         ` Pavel Machek
2010-09-30 19:55           ` Daniel Walker
2010-09-30 20:02             ` Pavel Machek
2010-09-30 20:08               ` Daniel Walker
2010-09-30 20:17                 ` Russell King - ARM Linux
2010-09-30 20:40                   ` Daniel Walker
2010-09-30 20:48                     ` Russell King - ARM Linux
2010-09-09 19:58 ` [PATCH 3/4] arm: mm: add proc info for ARM11MPCore/Cortex-A9 from ARM Daniel Walker
2010-09-13 12:05   ` Catalin Marinas
2010-09-09 19:58 ` Daniel Walker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284062289-10914-5-git-send-email-dwalker@codeaurora.org \
    --to=dwalker@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).