* [PATCH] ARM: mmu: Fix MT_MEMORY and MT_MEMORY_NONCACHED pte flags
@ 2010-09-29 16:43 Santosh Shilimkar
2010-09-29 16:52 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: Santosh Shilimkar @ 2010-09-29 16:43 UTC (permalink / raw)
To: linux-arm-kernel
The commit f1a2481c0 sets up the default flags for MT_MEMORY and
MT_MEMORY_NONCACHED memory types. L_PTE_USER flag is wrongly
set as default for these entries so remove it. Also adding
the 'L_PTE_WRITE' flag so that these pages become read-write
instead of just being read-only
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Reported-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
---
arch/arm/mm/mmu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index 6a3a2d0..e8ed9dc 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -248,7 +248,7 @@ static struct mem_type mem_types[] = {
},
[MT_MEMORY] = {
.prot_pte = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
- L_PTE_USER | L_PTE_EXEC,
+ L_PTE_WRITE | L_PTE_EXEC,
.prot_l1 = PMD_TYPE_TABLE,
.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE,
.domain = DOMAIN_KERNEL,
@@ -259,7 +259,7 @@ static struct mem_type mem_types[] = {
},
[MT_MEMORY_NONCACHED] = {
.prot_pte = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
- L_PTE_USER | L_PTE_EXEC | L_PTE_MT_BUFFERABLE,
+ L_PTE_WRITE | L_PTE_EXEC | L_PTE_MT_BUFFERABLE,
.prot_l1 = PMD_TYPE_TABLE,
.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE,
.domain = DOMAIN_KERNEL,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: mmu: Fix MT_MEMORY and MT_MEMORY_NONCACHED pte flags
2010-09-29 16:43 [PATCH] ARM: mmu: Fix MT_MEMORY and MT_MEMORY_NONCACHED pte flags Santosh Shilimkar
@ 2010-09-29 16:52 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2010-09-29 16:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2010-09-29 at 17:43 +0100, Santosh Shilimkar wrote:
> The commit f1a2481c0 sets up the default flags for MT_MEMORY and
> MT_MEMORY_NONCACHED memory types. L_PTE_USER flag is wrongly
> set as default for these entries so remove it. Also adding
> the 'L_PTE_WRITE' flag so that these pages become read-write
> instead of just being read-only
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Reported-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-29 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-29 16:43 [PATCH] ARM: mmu: Fix MT_MEMORY and MT_MEMORY_NONCACHED pte flags Santosh Shilimkar
2010-09-29 16:52 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).