From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend
Date: Thu, 30 Sep 2010 09:14:25 +0100 [thread overview]
Message-ID: <1285834465.9104.7.camel@e102144-lin.cambridge.arm.com> (raw)
In-Reply-To: <20100930010407.GA18073@linux-sh.org>
Paul,
On Thu, 2010-09-30 at 02:04 +0100, Paul Mundt wrote:
> On Mon, Sep 27, 2010 at 11:26:27PM +0100, Matt Fleming wrote:
> > On Tue, Sep 28, 2010 at 12:07:03AM +0200, Robert Richter wrote:
> > > On 27.09.10 16:01:38, Matt Fleming wrote:
> > > > Well, ARM doesn't have names as strings for its pmus currently. What's
> > > > more, ARM wouldn't use it; SH would be the only user of this function. I
> > > > don't think this one makes sense to be a generic function.
> > >
>
> Er, what? Yes it does. It has this silly id to string mapping thing that
> is at present duplicated between the perf and the oprofile code for no
> reason. Having a generic (albeit optional) perf_pmu_name() would allow
> this to be cleaned up.
>
It's not as silly as it appears. As you mention below, OProfile uses
strings to identify the correct CPU model in userspace. With ARM, there
is some horrible legacy here which means that the strings are extremely
misleading (arm/mpcore => arm/11mpcore, arm/armv7 => Cortex A8). Rather
than continue this mess into perf, I decided to separate the two and use
a common numeric scheme for when they have to talk to each other.
> > > As the implementation of the function would be optional, why should we
> > > make it architectural?
> >
> > I don't see why we should pollute the perf namespace with a function
> > that is only being used inside the SH oprofile code? There would be
> > exactly one use of this function and I doubt the perf guys will want
> > this function exposed. In it's current state, it really is no use to any
> > architecture other than SH.
> >
> This has nothing at all to do with the SH oprofile code and everything to
> do with oprofile in general. This is the vary basis for the CPU model
> matching in the oprofile userspace tools, it's string based by design.
> Given that we're already seeing architetures double up their strings in
> both places, this really wants a consensus and to be dealt with before
> other architetures start getting the wrong idea.
I agree that if you have sane strings for OProfile then there's no
reason to define new ones for perf.
Will
next prev parent reply other threads:[~2010-09-30 8:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-16 12:32 ` Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-16 12:55 ` Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Matt Fleming
2010-09-13 8:39 ` Will Deacon
2010-09-16 13:34 ` Robert Richter
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon [this message]
2010-09-13 7:13 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Marc Titinger
2010-09-13 7:50 ` Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285834465.9104.7.camel@e102144-lin.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).