From mboxrd@z Thu Jan  1 00:00:00 1970
From: ian@opensource.wolfsonmicro.com (Ian Lartey)
Date: Thu, 30 Sep 2010 15:49:31 +0100
Subject: [PATCH] Fixing ethernet driver compilation error for i.MX31
	ADS board
In-Reply-To: <20100930132914.GP29811@pengutronix.de>
References: <1285851444-18123-1-git-send-email-ian@opensource.wolfsonmicro.com>
	<20100930132914.GP29811@pengutronix.de>
Message-ID: <1285858171.1864.10033.camel@Tapajos>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, 2010-09-30 at 15:29 +0200, Uwe Kleine-K?nig wrote:
> Hi Ian,
> 
> On Thu, Sep 30, 2010 at 01:57:24PM +0100, Ian Lartey wrote:
> > This is only a partial revert of "ARM: mx3/mx31ads: fold board header in its only user"
> > [commit ccfa7c269843001077df02d98918c6c9bde91395)]
> > 
> > As some of the the board defines are also used in the cs89x0 ethernet driver by the i.MX31 ADS.
> Can you please line break the commit log.  AFAIK up to 76 chars are
> usual for the kernel.

Ah, sorry about that, I'll reformat the lines.

> 
> Hmmm, I took a look into drivers/net/cs89x0.c.  This driver definitly
> needs a cleanup, e.g. should start to provide a platform driver.
> Maybe it can even be merged with drivers/net/mac89x0.c?
> 
> I think the best for know would be the following:
> 
>  - reintroduce mach/board-mx31ads.h but only defining the symbols used
>    by cs89x0 together with a comment saying that the constants are
>    needed for the cs89x0 ethernet driver.

This time round I have just added the defines needed for the cs89x0 
to the ones that were moved back into mach-mx31ads.h from
mach-mx31ads.c . I think this is what you mean, yes ?

> 
>  - In a second patch add CS89x0 to mx31_defconfig

Will do.

> 
> Best regards
> Uwe
> 


Regards,
          Ian.