From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA494C3DA4A for ; Mon, 5 Aug 2024 09:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KNR8GgxZCqYzjbKBwZWIUoydo2N1AJIxO8v0mVVSeCQ=; b=bQ6gvWJYpL/I/8ZG9dceXBmYtA iGFoVdD/q6yLdqdt1Ks3sHQyohOfNuzriliWTVxx2DljuQpgeQijs4JQjy82meGJtAI1ofTXt69+A vJ1Ms3lbQP+B2yR6fNBbuTyb/MgSaAUXeJHF6Vgb52Eid7m96vMr06rfG33B8BKt8Cth3anw3Taj+ 14JAPJNOAoeFRccKnkBp3FGiioxhH9wfjFefFdmRdnVMpgMc5p2qVIFi2sQ/b4BITsqIj9ST2pOHc RV+/5jxrdgkbpAzhsv7kxHl5dzu7LNMa/KoJ/VONhDbjrICbA4pl2lSk6jPP89RSut0PNSZAaxd50 HKwJR4zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sauBJ-0000000FMH3-1jm0; Mon, 05 Aug 2024 09:39:09 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sau9B-0000000FKqb-0J0W; Mon, 05 Aug 2024 09:36:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=KNR8GgxZCqYzjbKBwZWIUoydo2N1AJIxO8v0mVVSeCQ=; b=qkSWUmHlQVCAhZmE7AiP6TOf6W 84wCE8qMEmcWr9uWVuYQ8BU9wa2FomVRqY06Fk84C4Xq1il3vIoajiZlTWy4CRyh+yleIxUdEGek/ NibBVddz0aIZg7ezEG2bXWYbnPDStMnGMRvC1nmsq7BAisHrb/fs6bXMlUupNyW/gaj4/5DeTDcCZ lIdaMgc+hvgMI1j35abdxanQ3MkgLBNY/FU8z1tW7Tvyvjz4VzFdMiN3tsrir/31VBzZxVmYij6FY V9vUv37dGeopEOZAemBRFSC3/J8d8QMuj+UO4fJbIPwp1gqA9OuewNcw/g3HF8B6mwWY9kPy6kQeY JrpQ6dgg==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sau97-00000006EFE-1q42; Mon, 05 Aug 2024 09:36:55 +0000 Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sau8v-0000TX-UA; Mon, 05 Aug 2024 11:36:41 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-kernel@vger.kernel.org, Detlev Casanova , Elaine Zhang Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Detlev Casanova , Geert Uytterhoeven , "Rafael J . Wysocki" , Finley Xiao , Jagan Teki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] soc: rockchip: power-domain: Add power domain support for rk3576 Date: Mon, 05 Aug 2024 11:36:40 +0200 Message-ID: <12859392.hYdu0Ggh8K@diego> In-Reply-To: <20240802151647.294307-4-detlev.casanova@collabora.com> References: <20240802151647.294307-1-detlev.casanova@collabora.com> <20240802151647.294307-4-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_103653_660101_AFAB94F4 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Detlev, Am Freitag, 2. August 2024, 17:15:00 CEST schrieb Detlev Casanova: > From: Finley Xiao with the power-domains now living somewhere else, the patch will need a different subject I think. > > This driver is modified to support RK3576 SoCs and lists the power domains. > > Signed-off-by: Finley Xiao > Signed-off-by: Detlev Casanova > @@ -552,7 +574,10 @@ static int rockchip_pd_power(struct rockchip_pm_domain *pd, bool power_on) > /* if powering up, leave idle mode */ > rockchip_pmu_set_idle_request(pd, false); > > - rockchip_pmu_restore_qos(pd); > + if (pd->info->delay_us) > + udelay(pd->info->delay_us); > + else > + rockchip_pmu_restore_qos(pd); the whole delay thing needs its own patch please. I.e. you're changing the inner workings of the driver here by not handling the qos settings and just waiting for a specific time. So I expect a lot more explanation on why that is the case and needed instead of it just happening when adding the soc-specific pieces. Does the rk3576 not have those qos settings and if so, why is there a delay necessary. This is not meant to disallow it, just that it needs its own commit with its own descriptive commit message :-) Heiko