From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mxc/gpio: make _set_value work with values != 0/1
Date: Mon, 11 Oct 2010 13:59:05 +0200 [thread overview]
Message-ID: <1286798345-32647-1-git-send-email-jacmet@sunsite.dk> (raw)
Documentation/gpio.txt specifies that the value argument to
gpio_set_value() should be handled as a boolean (E.G. != 0 is high),
so use the same logic as in _set_direction().
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
arch/arm/plat-mxc/gpio.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-mxc/gpio.c b/arch/arm/plat-mxc/gpio.c
index 57ec4a8..e226801 100644
--- a/arch/arm/plat-mxc/gpio.c
+++ b/arch/arm/plat-mxc/gpio.c
@@ -234,8 +234,13 @@ static void mxc_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
u32 l;
unsigned long flags;
+
spin_lock_irqsave(&port->lock, flags);
- l = (__raw_readl(reg) & (~(1 << offset))) | (value << offset);
+ l = __raw_readl(reg);
+ if (value)
+ l |= 1 << offset;
+ else
+ l &= ~(1 << offset);
__raw_writel(l, reg);
spin_unlock_irqrestore(&port->lock, flags);
}
--
1.7.1
next reply other threads:[~2010-10-11 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 11:59 Peter Korsgaard [this message]
2010-10-11 12:12 ` [PATCH] mxc/gpio: make _set_value work with values != 0/1 Marc Kleine-Budde
2010-10-11 12:18 ` Peter Korsgaard
2010-10-11 12:15 ` Uwe Kleine-König
2010-10-11 12:21 ` Peter Korsgaard
2010-10-11 13:19 ` Michał Nazarewicz
2010-10-11 12:17 ` Baruch Siach
2010-10-11 12:23 ` Peter Korsgaard
2010-10-11 12:39 ` Sascha Hauer
2010-10-11 12:47 ` Peter Korsgaard
2010-10-11 12:54 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286798345-32647-1-git-send-email-jacmet@sunsite.dk \
--to=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox